2022-04-22 22:42:11

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request

From: Luiz Augusto von Dentz <[email protected]>

This fixes the decoding of Enhanced Credit Connection Request which was
not accounting the fields correctly causing 2 extra Source CID to be
printed.
---
monitor/l2cap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/l2cap.c b/monitor/l2cap.c
index 4e449854a..01825ce0a 100644
--- a/monitor/l2cap.c
+++ b/monitor/l2cap.c
@@ -1331,7 +1331,7 @@ static void sig_ecred_conn_req(const struct l2cap_frame *frame)
const struct bt_l2cap_pdu_ecred_conn_req *pdu = frame->data;
uint16_t scid;

- l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
+ l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));

print_psm(pdu->psm);
print_field("MTU: %u", le16_to_cpu(pdu->mtu));
--
2.35.1


2022-04-22 23:06:20

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 20 Apr 2022 16:46:09 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This fixes the decoding of Enhanced Credit Connection Request which was
> not accounting the fields correctly causing 2 extra Source CID to be
> printed.
> ---
> monitor/l2cap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e2ad5009c0f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html