From: Luiz Augusto von Dentz <[email protected]>
When programming a new entry into the resolving list it shall default
to network mode since the params may contain the mode programmed when
the device was last added to the resolving list.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=209745
Fixes: 853b70b506a20 ("Bluetooth: hci_sync: Set Privacy Mode when updating the resolving list")
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
Tested-by: Zhengping Jiang <[email protected]>
---
v2: Use HCI_NETWORK_PRIVACY instead of 0x00
net/bluetooth/hci_sync.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ca97378fd81f..256ece5640b7 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -1636,6 +1636,9 @@ static int hci_le_add_resolve_list_sync(struct hci_dev *hdev,
bacpy(&cp.bdaddr, ¶ms->addr);
memcpy(cp.peer_irk, irk->val, 16);
+ /* Default privacy mode is always Network */
+ params->privacy_mode = HCI_NETWORK_PRIVACY;
+
done:
if (hci_dev_test_flag(hdev, HCI_PRIVACY))
memcpy(cp.local_irk, hdev->irk, 16);
--
2.35.3
From: Luiz Augusto von Dentz <[email protected]>
These devices are likely going to be reprogrammed when disconnected so
this avoid a whole bunch of commands attempt to remove and the add back
to the list.
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
---
net/bluetooth/hci_sync.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 256ece5640b7..c746714f218f 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -1892,12 +1892,15 @@ static u8 hci_update_accept_list_sync(struct hci_dev *hdev)
}
/* Go through the current accept list programmed into the
- * controller one by one and check if that address is still
- * in the list of pending connections or list of devices to
+ * controller one by one and check if that address is connected or is
+ * still in the list of pending connections or list of devices to
* report. If not present in either list, then remove it from
* the controller.
*/
list_for_each_entry_safe(b, t, &hdev->le_accept_list, list) {
+ if (hci_conn_hash_lookup_le(hdev, &b->bdaddr, b->bdaddr_type))
+ continue;
+
pend_conn = hci_pend_le_action_lookup(&hdev->pend_le_conns,
&b->bdaddr,
b->bdaddr_type);
--
2.35.3
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=659825
---Test result---
Test Summary:
CheckPatch PASS 1.84 seconds
GitLint PASS 0.88 seconds
SubjectPrefix PASS 0.57 seconds
BuildKernel PASS 38.85 seconds
BuildKernel32 PASS 34.10 seconds
Incremental Build with patchesPASS 56.43 seconds
TestRunner: Setup PASS 576.79 seconds
TestRunner: l2cap-tester PASS 18.82 seconds
TestRunner: bnep-tester PASS 6.65 seconds
TestRunner: mgmt-tester PASS 112.16 seconds
TestRunner: rfcomm-tester PASS 10.48 seconds
TestRunner: sco-tester PASS 10.12 seconds
TestRunner: smp-tester PASS 10.37 seconds
TestRunner: userchan-tester PASS 6.86 seconds
---
Regards,
Linux Bluetooth
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Thu, 14 Jul 2022 11:12:23 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> When programming a new entry into the resolving list it shall default
> to network mode since the params may contain the mode programmed when
> the device was last added to the resolving list.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209745
> Fixes: 853b70b506a20 ("Bluetooth: hci_sync: Set Privacy Mode when updating the resolving list")
> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
> Tested-by: Zhengping Jiang <[email protected]>
>
> [...]
Here is the summary with links:
- [v2,1/2] Bluetooth: hci_sync: Fix not updating privacy_mode
https://git.kernel.org/bluetooth/bluetooth-next/c/ab345b04433d
- [v2,2/2] Bluetooth: hci_sync: Don't remove connected devices from accept list
https://git.kernel.org/bluetooth/bluetooth-next/c/ff1688aab0d1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html