2022-10-20 23:03:03

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] client: Fix advertise.data command

From: Luiz Augusto von Dentz <[email protected]>

advertise.data when no parameter is given shall print what is set on
ad.data not the ad.manufacturer which is a different field set by
advertise.manufacturer.
---
client/advertising.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/advertising.c b/client/advertising.c
index 097b9437f794..fb9b049fde78 100644
--- a/client/advertising.c
+++ b/client/advertising.c
@@ -760,7 +760,7 @@ void ad_advertise_data(DBusConnection *conn, int argc, char *argv[])
struct ad_data data;

if (argc < 2 || !strlen(argv[1])) {
- if (ad.manufacturer.data.len) {
+ if (ad.data.data.len) {
bt_shell_printf("Type: 0x%02x\n", ad.data.type);
bt_shell_hexdump(ad.data.data.data, ad.data.data.len);
}
--
2.37.3


2022-10-21 00:40:49

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ] client: Fix advertise.data command

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=687318

---Test result---

Test Summary:
CheckPatch PASS 1.03 seconds
GitLint PASS 0.71 seconds
Prep - Setup ELL PASS 26.94 seconds
Build - Prep PASS 0.68 seconds
Build - Configure PASS 8.32 seconds
Build - Make PASS 763.73 seconds
Make Check PASS 11.17 seconds
Make Check w/Valgrind PASS 292.39 seconds
Make Distcheck PASS 241.02 seconds
Build w/ext ELL - Configure PASS 8.40 seconds
Build w/ext ELL - Make PASS 85.42 seconds
Incremental Build w/ patches PASS 0.00 seconds
Scan Build PASS 489.74 seconds



---
Regards,
Linux Bluetooth

2022-10-21 20:06:27

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ] client: Fix advertise.data command

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 20 Oct 2022 15:58:04 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> advertise.data when no parameter is given shall print what is set on
> ad.data not the ad.manufacturer which is a different field set by
> advertise.manufacturer.
> ---
> client/advertising.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ] client: Fix advertise.data command
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c8836711ad07

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html