2022-10-27 23:58:37

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH] Bluetooth: Add CONFIG_BT_LE_L2CAP_ECRED

From: Luiz Augusto von Dentz <[email protected]>

This adds CONFIG_BT_LE_L2CAP_ECRED which can be used to enable L2CAP
Enhanced Credit Flow Control Mode by default, previously it was only
possible to set it via module parameter (e.g. bluetooth.enable_ecred=1).

Since L2CAP ECRED mode is required by the likes of EATT which is
recommended for LE Audio this enables it by default.

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
---
net/bluetooth/Kconfig | 11 +++++++++++
net/bluetooth/l2cap_core.c | 2 +-
2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig
index ae3bdc6dfc92..da7cac0a1b71 100644
--- a/net/bluetooth/Kconfig
+++ b/net/bluetooth/Kconfig
@@ -78,6 +78,17 @@ config BT_LE
Bluetooth Low Energy includes support low-energy physical
layer available with Bluetooth version 4.0 or later.

+config BT_LE_L2CAP_ECRED
+ bool "Bluetooth L2CAP Enhanced Credit Flow Control"
+ depends on BT_LE
+ default y
+ help
+ Bluetooth Low Energy L2CAP Enhanced Credit Flow Control available with
+ Bluetooth version 5.2 or later.
+
+ This can be overridden by passing bluetooth.enable_ecred=[1|0]
+ on the kernel commandline.
+
config BT_6LOWPAN
tristate "Bluetooth 6LoWPAN support"
depends on BT_LE && 6LOWPAN
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 1fbe087d6ae4..ef725ed41303 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -45,7 +45,7 @@
#define LE_FLOWCTL_MAX_CREDITS 65535

bool disable_ertm;
-bool enable_ecred;
+bool enable_ecred = IS_ENABLED(CONFIG_BT_LE_L2CAP_ECRED);

static u32 l2cap_feat_mask = L2CAP_FEAT_FIXED_CHAN | L2CAP_FEAT_UCD;

--
2.37.3



2022-10-28 00:12:56

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: Add CONFIG_BT_LE_L2CAP_ECRED

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689611

---Test result---

Test Summary:
CheckPatch PASS 1.83 seconds
GitLint PASS 1.05 seconds
SubjectPrefix PASS 0.88 seconds
BuildKernel PASS 34.27 seconds
BuildKernel32 PASS 31.02 seconds
Incremental Build with patchesPASS 46.58 seconds
TestRunner: Setup PASS 514.95 seconds
TestRunner: l2cap-tester PASS 17.48 seconds
TestRunner: iso-tester PASS 16.75 seconds
TestRunner: bnep-tester PASS 6.64 seconds
TestRunner: mgmt-tester PASS 106.88 seconds
TestRunner: rfcomm-tester PASS 10.50 seconds
TestRunner: sco-tester PASS 9.95 seconds
TestRunner: ioctl-tester PASS 11.37 seconds
TestRunner: mesh-tester PASS 8.19 seconds
TestRunner: smp-tester PASS 10.02 seconds
TestRunner: userchan-tester PASS 6.99 seconds



---
Regards,
Linux Bluetooth

2022-10-28 23:59:10

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add CONFIG_BT_LE_L2CAP_ECRED

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 27 Oct 2022 16:25:28 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This adds CONFIG_BT_LE_L2CAP_ECRED which can be used to enable L2CAP
> Enhanced Credit Flow Control Mode by default, previously it was only
> possible to set it via module parameter (e.g. bluetooth.enable_ecred=1).
>
> Since L2CAP ECRED mode is required by the likes of EATT which is
> recommended for LE Audio this enables it by default.
>
> [...]

Here is the summary with links:
- Bluetooth: Add CONFIG_BT_LE_L2CAP_ECRED
https://git.kernel.org/bluetooth/bluetooth-next/c/98f18bb78b7d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html