2022-11-17 20:26:46

by Gix, Brian

Subject: [PATCH BlueZ] tools: Use portable 64 bit data formats

The isotest executable was using the non-portable %zd string formatter
for loging 64 bit integers. This replaces them with PRId64.
---
tools/isotest.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/isotest.c b/tools/isotest.c
index 8a50bfee8..dcd087ee1 100644
--- a/tools/isotest.c
+++ b/tools/isotest.c
@@ -30,6 +30,7 @@
#include <sys/uio.h>
#include <linux/sockios.h>
#include <time.h>
+#include <inttypes.h>

#include "lib/bluetooth.h"
#include "lib/hci.h"
@@ -589,12 +590,12 @@ static void send_wait(struct timespec *t_start, uint32_t us)
delta_us = us - TS_USEC(&t_diff);

if (delta_us < 0) {
- syslog(LOG_INFO, "Send is behind: %zd us", delta_us);
+ syslog(LOG_INFO, "Send is behind: %" PRId64 " us", delta_us);
delta_us = 1000;
}

if (!quiet)
- syslog(LOG_INFO, "Waiting (%zd us)...", delta_us);
+ syslog(LOG_INFO, "Waiting (%" PRId64 " us)...", delta_us);

usleep(delta_us);

--
2.38.1

2022-11-17 21:38:22

by bluez.test.bot

Subject: RE: [BlueZ] tools: Use portable 64 bit data formats

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696626

---Test result---

Test Summary:
CheckPatch PASS 0.62 seconds
GitLint PASS 0.42 seconds
Prep - Setup ELL PASS 31.52 seconds
Build - Prep PASS 0.67 seconds
Build - Configure PASS 9.93 seconds
Build - Make PASS 946.17 seconds
Make Check PASS 12.36 seconds
Make Check w/Valgrind PASS 342.45 seconds
Make Distcheck PASS 280.26 seconds
Build w/ext ELL - Configure PASS 10.14 seconds
Build w/ext ELL - Make PASS 100.46 seconds
Incremental Build w/ patches PASS 0.00 seconds
Scan Build PASS 597.33 seconds



---
Regards,
Linux Bluetooth

2022-11-18 00:31:59

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ] tools: Use portable 64 bit data formats

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 17 Nov 2022 12:21:50 -0800 you wrote:
> The isotest executable was using the non-portable %zd string formatter
> for loging 64 bit integers. This replaces them with PRId64.
> ---
> tools/isotest.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Here is the summary with links:
- [BlueZ] tools: Use portable 64 bit data formats
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=818adf28e518

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html