2022-12-09 18:06:10

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] client/player: Fix not calculating time to wait

From: Luiz Augusto von Dentz <[email protected]>

The difference of time start and current time may have advanced just
enough to add a second leaving start nanoseconds to be bigger.
---
client/player.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/client/player.c b/client/player.c
index 7f2b26b8791a..95309e101148 100644
--- a/client/player.c
+++ b/client/player.c
@@ -3396,6 +3396,10 @@ static void send_wait(struct timespec *t_start, uint32_t us)
}

t_diff.tv_sec = t_now.tv_sec - t_start->tv_sec;
+ if (t_start->tv_nsec > t_now.tv_nsec) {
+ t_diff.tv_sec--;
+ t_now.tv_nsec += 1000000000L;
+ }
t_diff.tv_nsec = t_now.tv_nsec - t_start->tv_nsec;

delta_us = us - TS_USEC(&t_diff);
--
2.37.3


2022-12-09 19:17:41

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ] client/player: Fix not calculating time to wait

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=703472

---Test result---

Test Summary:
CheckPatch PASS 0.50 seconds
GitLint PASS 0.33 seconds
BuildEll PASS 27.75 seconds
BluezMake PASS 902.16 seconds
MakeCheck PASS 11.54 seconds
MakeDistcheck PASS 152.81 seconds
CheckValgrind PASS 250.55 seconds
bluezmakeextell PASS 96.53 seconds
IncrementalBuild PASS 733.12 seconds
ScanBuild PASS 1040.94 seconds



---
Regards,
Linux Bluetooth

2022-12-09 21:41:58

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ] client/player: Fix not calculating time to wait

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Fri, 9 Dec 2022 10:03:12 -0800 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> The difference of time start and current time may have advanced just
> enough to add a second leaving start nanoseconds to be bigger.
> ---
> client/player.c | 4 ++++
> 1 file changed, 4 insertions(+)

Here is the summary with links:
- [BlueZ] client/player: Fix not calculating time to wait
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e07c1e723ee7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html