2023-06-20 21:12:57

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ 1/3] mgmt-api: Update Device Found Event documentation

From: Luiz Augusto von Dentz <[email protected]>

This updates Device Found Event documentation to mention the new flag
introduced to track when the event is generated due a interleaved Scan
Response that couldn't be merged.
---
doc/mgmt-api.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index c7191a028238..59e61d361dc2 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -4399,6 +4399,7 @@ Device Found Event
2 Not Connectable
3 Reserved (not in use)
4 Name Request Failed
+ 5 Scan Response

For the RSSI field a value of 127 indicates that the RSSI is
not available. That can happen with Bluetooth 1.1 and earlier
--
2.40.1



2023-06-20 21:41:37

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ 2/3] monitor: Add missing flags to MGMT Device Found Event

From: Luiz Augusto von Dentz <[email protected]>

This adds the missing flags to MGMT Device Found Event so they can be
decoded properly.
---
monitor/packet.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/monitor/packet.c b/monitor/packet.c
index 6d73e5abfcbc..4473fda29a46 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -12858,6 +12858,8 @@ static const struct bitfield_data mgmt_device_flags_table[] = {
{ 1, "Legacy Pairing" },
{ 2, "Not Connectable" },
{ 3, "Connection Locally Initiated" },
+ { 4, "Name Request Failed" },
+ { 5, "Scan Response" },
{ }
};

--
2.40.1


2023-06-20 22:43:07

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,1/3] mgmt-api: Update Device Found Event documentation

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=758865

---Test result---

Test Summary:
CheckPatch PASS 1.48 seconds
GitLint PASS 1.03 seconds
BuildEll PASS 26.57 seconds
BluezMake PASS 790.04 seconds
MakeCheck PASS 12.17 seconds
MakeDistcheck PASS 155.14 seconds
CheckValgrind PASS 248.12 seconds
CheckSmatch WARNING 335.64 seconds
bluezmakeextell PASS 101.25 seconds
IncrementalBuild PASS 1960.96 seconds
ScanBuild PASS 1008.06 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3552:52: warning: array of flexible structuresmonitor/bt.h:3540:40: warning: array of flexible structures


---
Regards,
Linux Bluetooth

2023-06-21 22:18:35

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ 1/3] mgmt-api: Update Device Found Event documentation

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 20 Jun 2023 13:40:51 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This updates Device Found Event documentation to mention the new flag
> introduced to track when the event is generated due a interleaved Scan
> Response that couldn't be merged.
> ---
> doc/mgmt-api.txt | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- [BlueZ,1/3] mgmt-api: Update Device Found Event documentation
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=98383b917a43
- [BlueZ,2/3] monitor: Add missing flags to MGMT Device Found Event
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=741a04aba0c3
- [BlueZ,3/3] adapter: Handle Device Found Event with Scan Response flag
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c8235156c31b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html