2023-11-29 08:08:02

by Zijun Hu

Subject: [PATCH v2 1/2] Bluetooth: hci_conn: Check non NULL before calling hdev->get_codec_config_data()

Explicitly add non NULL checking before calling
hdev->get_codec_config_data().

Signed-off-by: Zijun Hu <[email protected]>
---
net/bluetooth/hci_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index a09071059214..21b59d674717 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -346,7 +346,7 @@ static int hci_enhanced_setup_sync(struct hci_dev *hdev, void *data)
bt_dev_dbg(hdev, "hcon %p", conn);

/* for offload use case, codec needs to configured before opening SCO */
- if (conn->codec.data_path)
+ if (conn->codec.data_path && hdev->get_codec_config_data)
configure_datapath_sync(hdev, &conn->codec);

conn->state = BT_CONNECT;
--
The Qualcomm Innovation Center

2023-11-29 08:35:44

by bluez.test.bot

Subject: RE: Bluetooth: Support SCO offload for QCA2066

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=805140

---Test result---

Test Summary:
CheckPatch PASS 1.33 seconds
GitLint FAIL 0.89 seconds
SubjectPrefix PASS 0.24 seconds
BuildKernel PASS 27.02 seconds
CheckAllWarning PASS 29.61 seconds
CheckSparse PASS 34.81 seconds
CheckSmatch PASS 97.72 seconds
BuildKernel32 PASS 26.45 seconds
TestRunnerSetup PASS 410.97 seconds
TestRunner_l2cap-tester PASS 22.93 seconds
TestRunner_iso-tester PASS 48.04 seconds
TestRunner_bnep-tester PASS 6.91 seconds
TestRunner_mgmt-tester PASS 166.21 seconds
TestRunner_rfcomm-tester PASS 14.04 seconds
TestRunner_sco-tester PASS 14.48 seconds
TestRunner_ioctl-tester PASS 12.16 seconds
TestRunner_mesh-tester PASS 8.81 seconds
TestRunner_smp-tester PASS 9.77 seconds
TestRunner_userchan-tester PASS 7.34 seconds
IncrementalBuild PASS 30.02 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v2,1/2] Bluetooth: hci_conn: Check non NULL before calling hdev->get_codec_config_data()

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (89>80): "[v2,1/2] Bluetooth: hci_conn: Check non NULL before calling hdev->get_codec_config_data()"


---
Regards,
Linux Bluetooth