2023-12-14 14:37:02

by Zijun Hu

Subject: [PATCH v1 1/1] Bluetooth: hci_event: Fix power save marking logic

Flag HCI_CONN_POWER_SAVE stands for sniff mode, but hci_mode_change_evt()
wrongly set the flag for active mode and clear for sniff mode, it is fixed
by reversing power save marking logic.

Signed-off-by: Zijun Hu <[email protected]>
---
net/bluetooth/hci_event.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index ef8c3bed7361..74a14f2e0eaa 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -4601,9 +4601,9 @@ static void hci_mode_change_evt(struct hci_dev *hdev, void *data,
if (!test_and_clear_bit(HCI_CONN_MODE_CHANGE_PEND,
&conn->flags)) {
if (conn->mode == HCI_CM_ACTIVE)
- set_bit(HCI_CONN_POWER_SAVE, &conn->flags);
- else
clear_bit(HCI_CONN_POWER_SAVE, &conn->flags);
+ else
+ set_bit(HCI_CONN_POWER_SAVE, &conn->flags);
}

if (test_and_clear_bit(HCI_CONN_SCO_SETUP_PEND, &conn->flags))
--
The Qualcomm Innovation Center

2023-12-14 15:33:51

by bluez.test.bot

Subject: RE: [v1,1/1] Bluetooth: hci_event: Fix power save marking logic

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=810094

---Test result---

Test Summary:
CheckPatch PASS 0.47 seconds
GitLint PASS 0.22 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 27.62 seconds
CheckAllWarning PASS 31.20 seconds
CheckSparse WARNING 38.14 seconds
CheckSmatch WARNING 100.22 seconds
BuildKernel32 PASS 27.91 seconds
TestRunnerSetup PASS 432.22 seconds
TestRunner_l2cap-tester PASS 23.62 seconds
TestRunner_iso-tester PASS 48.32 seconds
TestRunner_bnep-tester PASS 7.07 seconds
TestRunner_mgmt-tester PASS 167.01 seconds
TestRunner_rfcomm-tester PASS 10.94 seconds
TestRunner_sco-tester PASS 14.59 seconds
TestRunner_ioctl-tester PASS 12.25 seconds
TestRunner_mesh-tester PASS 8.83 seconds
TestRunner_smp-tester PASS 9.93 seconds
TestRunner_userchan-tester PASS 7.36 seconds
IncrementalBuild PASS 25.83 seconds

Details
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):


---
Regards,
Linux Bluetooth