2024-02-07 16:17:37

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ v1] mgmt-tester: Remove High Speed test cases

From: Luiz Augusto von Dentz <[email protected]>

High Speed is has been removed so these tests are not run anymore so
they can be safely removed.
---
tools/mgmt-tester.c | 63 ---------------------------------------------
1 file changed, 63 deletions(-)

diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index 2411267bcb4c..e85fbacdacec 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -1688,53 +1688,6 @@ static const struct generic_data set_sc_only_on_success_test_2 = {
.expect_hci_len = sizeof(set_sc_on_write_sc_support_param),
};

-static const char set_hs_on_param[] = { 0x01 };
-static const char set_hs_invalid_param[] = { 0x02 };
-static const char set_hs_garbage_param[] = { 0x01, 0x00 };
-static const char set_hs_settings_param_1[] = { 0xc0, 0x01, 0x00, 0x00 };
-
-static const struct generic_data set_hs_on_success_test = {
- .setup_settings = settings_ssp,
- .send_opcode = MGMT_OP_SET_HS,
- .send_param = set_hs_on_param,
- .send_len = sizeof(set_hs_on_param),
- .expect_status = MGMT_STATUS_SUCCESS,
- .expect_param = set_hs_settings_param_1,
- .expect_len = sizeof(set_hs_settings_param_1),
- .expect_settings_set = MGMT_SETTING_HS,
-};
-
-static const struct generic_data set_hs_on_invalid_param_test_1 = {
- .setup_settings = settings_ssp,
- .send_opcode = MGMT_OP_SET_HS,
- .expect_status = MGMT_STATUS_INVALID_PARAMS,
-};
-
-static const struct generic_data set_hs_on_invalid_param_test_2 = {
- .setup_settings = settings_ssp,
- .send_opcode = MGMT_OP_SET_HS,
- .send_param = set_hs_invalid_param,
- .send_len = sizeof(set_hs_invalid_param),
- .expect_status = MGMT_STATUS_INVALID_PARAMS,
-};
-
-static const struct generic_data set_hs_on_invalid_param_test_3 = {
- .setup_settings = settings_ssp,
- .send_opcode = MGMT_OP_SET_HS,
- .send_param = set_hs_garbage_param,
- .send_len = sizeof(set_hs_garbage_param),
- .expect_status = MGMT_STATUS_INVALID_PARAMS,
-};
-
-static const struct generic_data set_hs_on_invalid_index_test = {
- .setup_settings = settings_ssp,
- .send_index_none = true,
- .send_opcode = MGMT_OP_SET_HS,
- .send_param = set_hs_on_param,
- .send_len = sizeof(set_hs_on_param),
- .expect_status = MGMT_STATUS_INVALID_INDEX,
-};
-
static uint16_t settings_le[] = { MGMT_OP_SET_LE, 0 };

static const char set_le_on_param[] = { 0x01 };
@@ -13088,22 +13041,6 @@ int main(int argc, char *argv[])
&set_sc_only_on_success_test_2,
NULL, test_command_generic);

- test_hs("Set High Speed on - Success",
- &set_hs_on_success_test,
- NULL, test_command_generic);
- test_hs("Set High Speed on - Invalid parameters 1",
- &set_hs_on_invalid_param_test_1,
- NULL, test_command_generic);
- test_hs("Set High Speed on - Invalid parameters 2",
- &set_hs_on_invalid_param_test_2,
- NULL, test_command_generic);
- test_hs("Set High Speed on - Invalid parameters 3",
- &set_hs_on_invalid_param_test_3,
- NULL, test_command_generic);
- test_hs("Set High Speed on - Invalid index",
- &set_hs_on_invalid_index_test,
- NULL, test_command_generic);
-
test_bredrle("Set Low Energy on - Success 1",
&set_le_on_success_test_1,
NULL, test_command_generic);
--
2.43.0



2024-02-07 17:32:04

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v1] mgmt-tester: Remove High Speed test cases

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=824008

---Test result---

Test Summary:
CheckPatch PASS 0.42 seconds
GitLint PASS 0.31 seconds
BuildEll PASS 26.09 seconds
BluezMake PASS 713.17 seconds
MakeCheck PASS 12.14 seconds
MakeDistcheck PASS 161.76 seconds
CheckValgrind PASS 225.61 seconds
CheckSmatch PASS 327.28 seconds
bluezmakeextell PASS 107.16 seconds
IncrementalBuild PASS 658.91 seconds
ScanBuild PASS 930.78 seconds



---
Regards,
Linux Bluetooth

2024-02-08 13:51:40

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ v1] mgmt-tester: Remove High Speed test cases

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 7 Feb 2024 11:17:24 -0500 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> High Speed is has been removed so these tests are not run anymore so
> they can be safely removed.
> ---
> tools/mgmt-tester.c | 63 ---------------------------------------------
> 1 file changed, 63 deletions(-)

Here is the summary with links:
- [BlueZ,v1] mgmt-tester: Remove High Speed test cases
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5135613ce057

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html