2024-03-04 18:43:07

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ v2] build: Fix distcheck

From: Luiz Augusto von Dentz <[email protected]>

This fixes the following errors:

/usr/bin/mkdir -p '/backend'
/usr/bin/mkdir: cannot create directory ‘/backend’: Permission denied
make[3]: *** [Makefile:4768: install-cupsPROGRAMS] Error 1
---
Makefile.tools | 6 +++++-
configure.ac | 8 +++++++-
2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/Makefile.tools b/Makefile.tools
index c17244677673..27a753762d1c 100644
--- a/Makefile.tools
+++ b/Makefile.tools
@@ -539,7 +539,11 @@ endif

if CUPS

-cupsdir = $(CUPSDIR)
+if CUPS_SERVERBIN
+cupsdir = $(CUPS_SERVERBIN)/backend
+else
+cupsdir = $(libdir)/cups/backend
+endif

cups_PROGRAMS = profiles/cups/bluetooth

diff --git a/configure.ac b/configure.ac
index af0e9900e732..6552154a86dd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -247,7 +247,13 @@ AC_ARG_ENABLE(cups, AS_HELP_STRING([--disable-cups],
[disable CUPS printer support]), [enable_cups=${enableval}])
AM_CONDITIONAL(CUPS, test "${enable_cups}" != "no")
if (test "${enable_cups}" != "no"); then
- AC_SUBST(CUPSDIR, `$PKG_CONFIG cups --variable=cups_serverbin`/backend)
+ AC_MSG_CHECKING([cups directory])
+ cups_serverbin=`$PKG_CONFIG cups --variable=cups_serverbin`
+ AM_CONDITIONAL(CUPS_SERVERBIN, test "${cups_serverbin}" != "")
+ if (test "${cups_serverbin}" != ""); then
+ AC_SUBST(CUPS_SERVERBIN, ${cups_serverbin})
+ fi
+ AC_MSG_RESULT([${cups_serverbin}])
fi

AC_ARG_ENABLE(mesh, AS_HELP_STRING([--enable-mesh],
--
2.43.0

2024-03-04 19:12:02

by bluez.test.bot

Subject: RE: [BlueZ,v2] build: Fix distcheck

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=832197

---Test result---

Test Summary:
CheckPatch PASS 0.43 seconds
GitLint PASS 0.32 seconds
BuildEll PASS 24.02 seconds
BluezMake PASS 715.93 seconds
MakeCheck PASS 16.20 seconds
MakeDistcheck PASS 164.75 seconds
CheckValgrind PASS 228.43 seconds
CheckSmatch PASS 332.92 seconds
bluezmakeextell PASS 107.72 seconds
IncrementalBuild PASS 672.76 seconds
ScanBuild PASS 959.32 seconds



---
Regards,
Linux Bluetooth

2024-03-04 20:11:00

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v2] build: Fix distcheck

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Mon, 4 Mar 2024 13:11:57 -0500 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This fixes the following errors:
>
> /usr/bin/mkdir -p '/backend'
> /usr/bin/mkdir: cannot create directory ‘/backend’: Permission denied
> make[3]: *** [Makefile:4768: install-cupsPROGRAMS] Error 1
>
> [...]

Here is the summary with links:
- [BlueZ,v2] build: Fix distcheck
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d5a9195a6269

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html