2024-03-20 18:30:49

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ v1] shared/btsnoop: Add proper identifiers for ISO packets

From: Luiz Augusto von Dentz <[email protected]>

This adds ISO packets identifiers so they are properly stored on files.
---
src/shared/btsnoop.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/src/shared/btsnoop.c b/src/shared/btsnoop.c
index 8b93203b3..bc5f7fcbe 100644
--- a/src/shared/btsnoop.c
+++ b/src/shared/btsnoop.c
@@ -305,6 +305,9 @@ static uint32_t get_flags_from_opcode(uint16_t opcode)
case BTSNOOP_OPCODE_SCO_TX_PKT:
case BTSNOOP_OPCODE_SCO_RX_PKT:
break;
+ case BTSNOOP_OPCODE_ISO_TX_PKT:
+ case BTSNOOP_OPCODE_ISO_RX_PKT:
+ break;
case BTSNOOP_OPCODE_OPEN_INDEX:
case BTSNOOP_OPCODE_CLOSE_INDEX:
break;
@@ -428,6 +431,14 @@ static bool pklg_read_hci(struct btsnoop *btsnoop, struct timeval *tv,
*index = 0x0000;
*opcode = BTSNOOP_OPCODE_SCO_RX_PKT;
break;
+ case 0x12:
+ *index = 0x0000;
+ *opcode = BTSNOOP_OPCODE_ISO_TX_PKT;
+ break;
+ case 0x13:
+ *index = 0x0000;
+ *opcode = BTSNOOP_OPCODE_ISO_RX_PKT;
+ break;
case 0x0b:
*index = 0x0000;
*opcode = BTSNOOP_OPCODE_VENDOR_DIAG;
@@ -470,6 +481,11 @@ static uint16_t get_opcode_from_flags(uint8_t type, uint32_t flags)
return BTSNOOP_OPCODE_SCO_TX_PKT;
case 0x04:
return BTSNOOP_OPCODE_EVENT_PKT;
+ case 0x05:
+ if (flags & 0x01)
+ return BTSNOOP_OPCODE_ISO_RX_PKT;
+ else
+ return BTSNOOP_OPCODE_ISO_TX_PKT;
case 0xff:
if (flags & 0x02) {
if (flags & 0x01)
--
2.44.0

2024-03-20 20:04:26

by bluez.test.bot

Subject: RE: [BlueZ,v1] shared/btsnoop: Add proper identifiers for ISO packets

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=836816

---Test result---

Test Summary:
CheckPatch PASS 0.45 seconds
GitLint PASS 0.32 seconds
BuildEll PASS 24.02 seconds
BluezMake PASS 1746.26 seconds
MakeCheck PASS 13.24 seconds
MakeDistcheck PASS 176.76 seconds
CheckValgrind PASS 248.79 seconds
CheckSmatch PASS 353.43 seconds
bluezmakeextell PASS 120.04 seconds
IncrementalBuild PASS 1488.60 seconds
ScanBuild PASS 996.75 seconds



---
Regards,
Linux Bluetooth

2024-03-22 10:10:44

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v1] shared/btsnoop: Add proper identifiers for ISO packets

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 20 Mar 2024 18:30:37 +0000 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This adds ISO packets identifiers so they are properly stored on files.
> ---
> src/shared/btsnoop.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)

Here is the summary with links:
- [BlueZ,v1] shared/btsnoop: Add proper identifiers for ISO packets
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9250929edde3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html