2024-03-22 14:38:43

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ v2] bap: Fix not setting adapter address type

From: Luiz Augusto von Dentz <[email protected]>

This fixes not setting adapter address type when listening/connecting
ISO sockets which prevents them working when adapter comes unconfigured
which then gets assigned a random address.
---
profiles/audio/bap.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 964ba9c21..315eff729 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -1856,6 +1856,8 @@ static void setup_connect_io(struct bap_data *data, struct bap_setup *setup,
io = bt_io_connect(bap_connect_io_cb, setup, NULL, &err,
BT_IO_OPT_SOURCE_BDADDR,
btd_adapter_get_address(adapter),
+ BT_IO_OPT_SOURCE_TYPE,
+ btd_adapter_get_address_type(data->adapter),
BT_IO_OPT_DEST_BDADDR,
device_get_address(data->device),
BT_IO_OPT_DEST_TYPE,
@@ -1912,6 +1914,8 @@ static void setup_connect_io_broadcast(struct bap_data *data,
io = bt_io_connect(bap_connect_bcast_io_cb, setup, NULL, &err,
BT_IO_OPT_SOURCE_BDADDR,
btd_adapter_get_address(adapter),
+ BT_IO_OPT_SOURCE_TYPE,
+ btd_adapter_get_address_type(adapter),
BT_IO_OPT_DEST_BDADDR,
&dst_addr,
BT_IO_OPT_DEST_TYPE,
@@ -1952,6 +1956,8 @@ static void setup_listen_io(struct bap_data *data, struct bt_bap_stream *stream,
io = bt_io_listen(NULL, iso_confirm_cb, data, NULL, &err,
BT_IO_OPT_SOURCE_BDADDR,
btd_adapter_get_address(adapter),
+ BT_IO_OPT_SOURCE_TYPE,
+ btd_adapter_get_address_type(adapter),
BT_IO_OPT_DEST_BDADDR,
BDADDR_ANY,
BT_IO_OPT_DEST_TYPE,
@@ -2734,6 +2740,8 @@ static int short_lived_pa_sync(struct bap_bcast_pa_req *req)
NULL, &err,
BT_IO_OPT_SOURCE_BDADDR,
btd_adapter_get_address(data->adapter),
+ BT_IO_OPT_SOURCE_TYPE,
+ btd_adapter_get_address_type(data->adapter),
BT_IO_OPT_DEST_BDADDR,
device_get_address(data->device),
BT_IO_OPT_DEST_TYPE,
--
2.44.0

2024-03-22 15:50:33

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v2] bap: Fix not setting adapter address type

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Fri, 22 Mar 2024 14:38:31 +0000 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This fixes not setting adapter address type when listening/connecting
> ISO sockets which prevents them working when adapter comes unconfigured
> which then gets assigned a random address.
> ---
> profiles/audio/bap.c | 8 ++++++++
> 1 file changed, 8 insertions(+)

Here is the summary with links:
- [BlueZ,v2] bap: Fix not setting adapter address type
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=87cabb267935

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2024-03-22 16:42:45

by bluez.test.bot

Subject: RE: [BlueZ,v2] bap: Fix not setting adapter address type

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=837395

---Test result---

Test Summary:
CheckPatch PASS 0.47 seconds
GitLint PASS 0.34 seconds
BuildEll PASS 28.46 seconds
BluezMake PASS 1812.86 seconds
MakeCheck PASS 13.27 seconds
MakeDistcheck PASS 174.03 seconds
CheckValgrind PASS 244.31 seconds
CheckSmatch PASS 345.36 seconds
bluezmakeextell PASS 117.25 seconds
IncrementalBuild PASS 1611.38 seconds
ScanBuild PASS 979.13 seconds



---
Regards,
Linux Bluetooth