Hello,
this series converts all platform drivers below drivers/bluetooth to
stop using struct platform_driver::remove(). See commit 5c5a7680e67b
("platform: Provide a remove callback that returns no value") for an
extended explanation and the eventual goal.
All conversations are trivial, because the driver's .remove() callbacks
returned zero unconditionally.
There are no interdependencies between these patches, still I'd expect
them to be picked up together. This is merge window material.
Best regards
Uwe
Uwe Kleine-König (3):
Bluetooth: btqcomsmd: Convert to platform remove callback returning void
Bluetooth: hci_bcm: Convert to platform remove callback returning void
Bluetooth: hci_intel: Convert to platform remove callback returning void
drivers/bluetooth/btqcomsmd.c | 6 ++----
drivers/bluetooth/hci_bcm.c | 6 ++----
drivers/bluetooth/hci_intel.c | 6 ++----
3 files changed, 6 insertions(+), 12 deletions(-)
base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
--
2.43.0
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/bluetooth/btqcomsmd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
index 11c7e04bf394..88dbb2f3fabf 100644
--- a/drivers/bluetooth/btqcomsmd.c
+++ b/drivers/bluetooth/btqcomsmd.c
@@ -197,7 +197,7 @@ static int btqcomsmd_probe(struct platform_device *pdev)
return ret;
}
-static int btqcomsmd_remove(struct platform_device *pdev)
+static void btqcomsmd_remove(struct platform_device *pdev)
{
struct btqcomsmd *btq = platform_get_drvdata(pdev);
@@ -206,8 +206,6 @@ static int btqcomsmd_remove(struct platform_device *pdev)
rpmsg_destroy_ept(btq->cmd_channel);
rpmsg_destroy_ept(btq->acl_channel);
-
- return 0;
}
static const struct of_device_id btqcomsmd_of_match[] = {
@@ -218,7 +216,7 @@ MODULE_DEVICE_TABLE(of, btqcomsmd_of_match);
static struct platform_driver btqcomsmd_driver = {
.probe = btqcomsmd_probe,
- .remove = btqcomsmd_remove,
+ .remove_new = btqcomsmd_remove,
.driver = {
.name = "btqcomsmd",
.of_match_table = btqcomsmd_of_match,
--
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=834459
---Test result---
Test Summary:
CheckPatch PASS 1.35 seconds
GitLint PASS 0.57 seconds
SubjectPrefix PASS 0.16 seconds
BuildKernel PASS 28.56 seconds
CheckAllWarning PASS 31.80 seconds
CheckSparse PASS 38.05 seconds
CheckSmatch PASS 100.92 seconds
BuildKernel32 PASS 27.96 seconds
TestRunnerSetup PASS 527.76 seconds
TestRunner_l2cap-tester PASS 20.27 seconds
TestRunner_iso-tester PASS 30.53 seconds
TestRunner_bnep-tester PASS 4.71 seconds
TestRunner_mgmt-tester PASS 112.60 seconds
TestRunner_rfcomm-tester PASS 7.34 seconds
TestRunner_sco-tester PASS 14.88 seconds
TestRunner_ioctl-tester PASS 7.75 seconds
TestRunner_mesh-tester PASS 7.51 seconds
TestRunner_smp-tester PASS 6.82 seconds
TestRunner_userchan-tester PASS 5.17 seconds
IncrementalBuild PASS 35.48 seconds
---
Regards,
Linux Bluetooth
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Mon, 11 Mar 2024 22:49:51 +0100 you wrote:
> Hello,
>
> this series converts all platform drivers below drivers/bluetooth to
> stop using struct platform_driver::remove(). See commit 5c5a7680e67b
> ("platform: Provide a remove callback that returns no value") for an
> extended explanation and the eventual goal.
>
> [...]
Here is the summary with links:
- [1/3] Bluetooth: btqcomsmd: Convert to platform remove callback returning void
https://git.kernel.org/bluetooth/bluetooth-next/c/5bffd666f4ac
- [2/3] Bluetooth: hci_bcm: Convert to platform remove callback returning void
https://git.kernel.org/bluetooth/bluetooth-next/c/526f6c35de83
- [3/3] Bluetooth: hci_intel: Convert to platform remove callback returning void
https://git.kernel.org/bluetooth/bluetooth-next/c/0dc3ce6b3c1f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html