From: Luiz Augusto von Dentz <[email protected]>
Some attributes may require to generate
BT_ERROR_CCC_IMPROPERLY_CONFIGURED when its CCC is not properly
configured so this adds the possibility to generate it by replying with
org.bluez.Error.ImproperlyConfigured error to WriteValue.
---
doc/org.bluez.GattCharacteristic.rst | 1 +
doc/org.bluez.GattDescriptor.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/doc/org.bluez.GattCharacteristic.rst b/doc/org.bluez.GattCharacteristic.rst
index cd5a0d0c788f..b7e4a7b69c9e 100644
--- a/doc/org.bluez.GattCharacteristic.rst
+++ b/doc/org.bluez.GattCharacteristic.rst
@@ -133,6 +133,7 @@ void WriteValue(array{byte} value, dict options)
:org.bluez.Error.InvalidValueLength:
:org.bluez.Error.NotAuthorized:
:org.bluez.Error.NotSupported:
+ :org.bluez.Error.ImproperlyConfigured:
fd, uint16 AcquireWrite(dict options) [optional]
````````````````````````````````````````````````
diff --git a/doc/org.bluez.GattDescriptor.rst b/doc/org.bluez.GattDescriptor.rst
index 94cc8b26af29..f4497c6d5b15 100644
--- a/doc/org.bluez.GattDescriptor.rst
+++ b/doc/org.bluez.GattDescriptor.rst
@@ -115,6 +115,7 @@ void WriteValue(array{byte} value, dict flags)
:org.bluez.Error.InvalidValueLength:
:org.bluez.Error.NotAuthorized:
:org.bluez.Error.NotSupported:
+ :org.bluez.Error.ImproperlyConfigured:
Properties
----------
--
2.44.0
From: Luiz Augusto von Dentz <[email protected]>
This implements support for handling when applications reply with
org.bluez.Error.ImproperlyConfigured the code will translate it to
BT_ERROR_CCC_IMPROPERLY_CONFIGURED.
Fixes: https://github.com/bluez/bluez/issues/827
---
src/gatt-database.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gatt-database.c b/src/gatt-database.c
index 7ca2f94222c6..d028ce012b99 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -2248,6 +2248,9 @@ static uint8_t dbus_error_to_att_ecode(const char *name, const char *msg,
if (strcmp(name, ERROR_INTERFACE ".InProgress") == 0)
return BT_ERROR_ALREADY_IN_PROGRESS;
+ if (strcmp(name, ERROR_INTERFACE ".ImproperlyConfigured"))
+ return BT_ERROR_CCC_IMPROPERLY_CONFIGURED;
+
if (strcmp(name, ERROR_INTERFACE ".NotPermitted") == 0)
return perm_err;
--
2.44.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=848285
---Test result---
Test Summary:
CheckPatch PASS 0.88 seconds
GitLint FAIL 0.82 seconds
BuildEll PASS 28.35 seconds
BluezMake PASS 1800.99 seconds
MakeCheck PASS 13.23 seconds
MakeDistcheck PASS 183.76 seconds
CheckValgrind PASS 253.94 seconds
CheckSmatch PASS 357.66 seconds
bluezmakeextell PASS 122.10 seconds
IncrementalBuild PASS 3066.12 seconds
ScanBuild PASS 1025.88 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1,1/2] org.bluez.Gatt: Add org.bluez.Error.ImproperlyConfigured error to WriteValue
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (91>80): "[BlueZ,v1,1/2] org.bluez.Gatt: Add org.bluez.Error.ImproperlyConfigured error to WriteValue"
[BlueZ,v1,2/2] gatt-database: Implement support to org.bluez.Error.ImproperlyConfigured
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (87>80): "[BlueZ,v1,2/2] gatt-database: Implement support to org.bluez.Error.ImproperlyConfigured"
---
Regards,
Linux Bluetooth
Hello:
This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Fri, 26 Apr 2024 10:48:25 -0400 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> Some attributes may require to generate
> BT_ERROR_CCC_IMPROPERLY_CONFIGURED when its CCC is not properly
> configured so this adds the possibility to generate it by replying with
> org.bluez.Error.ImproperlyConfigured error to WriteValue.
>
> [...]
Here is the summary with links:
- [BlueZ,v1,1/2] org.bluez.Gatt: Add org.bluez.Error.ImproperlyConfigured error to WriteValue
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=129b19166304
- [BlueZ,v1,2/2] gatt-database: Implement support to org.bluez.Error.ImproperlyConfigured
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9b29784717f4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html