2024-05-01 19:28:25

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ v1] src/shared: Make default length handle EA

From: Luiz Augusto von Dentz <[email protected]>

By default bt_ad was setting just BT_AD_MAX_DATA_LEN (31) which is not
enough to handle devices advertising using EA, so this switches the
default to be BT_EA_MAX_DATA_LEN (251) since EA is much more common
nowadays and for those case where the it is not supported (e.g. for
advertisers without EA support) then shall be using bt_ad_set_max_len
to adjust the maximum length.

Fixes: https://github.com/bluez/bluez/issues/832
---
src/shared/ad.c | 2 +-
src/shared/ad.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/shared/ad.c b/src/shared/ad.c
index 2d6fc628eabc..f3fb428e25c6 100644
--- a/src/shared/ad.c
+++ b/src/shared/ad.c
@@ -48,7 +48,7 @@ struct bt_ad *bt_ad_new(void)
struct bt_ad *ad;

ad = new0(struct bt_ad, 1);
- ad->max_len = BT_AD_MAX_DATA_LEN;
+ ad->max_len = BT_EA_MAX_DATA_LEN;
ad->service_uuids = queue_new();
ad->manufacturer_data = queue_new();
ad->solicit_uuids = queue_new();
diff --git a/src/shared/ad.h b/src/shared/ad.h
index 820b9177562b..11900706f9ed 100644
--- a/src/shared/ad.h
+++ b/src/shared/ad.h
@@ -15,6 +15,7 @@
#include "lib/uuid.h"

#define BT_AD_MAX_DATA_LEN 31
+#define BT_EA_MAX_DATA_LEN 251
#define BT_PA_MAX_DATA_LEN 252

#define BT_AD_FLAGS 0x01
--
2.44.0

2024-05-01 21:04:42

by bluez.test.bot

Subject: RE: [BlueZ,v1] src/shared: Make default length handle EA

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=849727

---Test result---

Test Summary:
CheckPatch PASS 0.40 seconds
GitLint PASS 0.29 seconds
BuildEll PASS 24.58 seconds
BluezMake PASS 1740.81 seconds
MakeCheck PASS 13.03 seconds
MakeDistcheck PASS 182.12 seconds
CheckValgrind PASS 249.53 seconds
CheckSmatch PASS 351.21 seconds
bluezmakeextell PASS 119.59 seconds
IncrementalBuild PASS 1507.30 seconds
ScanBuild PASS 993.87 seconds



---
Regards,
Linux Bluetooth

2024-05-02 14:41:17

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v1] src/shared: Make default length handle EA

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 1 May 2024 15:28:12 -0400 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> By default bt_ad was setting just BT_AD_MAX_DATA_LEN (31) which is not
> enough to handle devices advertising using EA, so this switches the
> default to be BT_EA_MAX_DATA_LEN (251) since EA is much more common
> nowadays and for those case where the it is not supported (e.g. for
> advertisers without EA support) then shall be using bt_ad_set_max_len
> to adjust the maximum length.
>
> [...]

Here is the summary with links:
- [BlueZ,v1] src/shared: Make default length handle EA
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f40c5857d70a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html