2024-05-11 10:32:33

by Pauli Virtanen

Subject: [PATCH BlueZ] tools: fix using too small buffers in test-runner

Fix compiler warning:

tools/test-runner.c:309:57: error: 'sprintf' may write a terminating nul
past the end of the destination [-Werror=format-overflow=]
---
tools/test-runner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index 243eab468..5bdcf42fc 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -302,10 +302,10 @@ static void start_qemu(void)
const char *path = "/tmp/bt-server-bredr";
char *chrdev, *serdev;

- chrdev = alloca(32 + strlen(path));
+ chrdev = alloca(48 + strlen(path));
sprintf(chrdev, "socket,path=%s,id=bt%d", path, i);

- serdev = alloca(32);
+ serdev = alloca(48);
sprintf(serdev, "pci-serial,chardev=bt%d", i);

argv[pos++] = "-chardev";
--
2.45.0

2024-05-11 12:00:07

by bluez.test.bot

Subject: RE: [BlueZ] tools: fix using too small buffers in test-runner

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=852514

---Test result---

Test Summary:
CheckPatch PASS 0.45 seconds
GitLint PASS 0.32 seconds
BuildEll PASS 24.29 seconds
BluezMake PASS 1620.69 seconds
MakeCheck PASS 13.30 seconds
MakeDistcheck PASS 176.44 seconds
CheckValgrind PASS 249.65 seconds
CheckSmatch PASS 349.86 seconds
bluezmakeextell PASS 118.87 seconds
IncrementalBuild PASS 1419.35 seconds
ScanBuild PASS 982.15 seconds



---
Regards,
Linux Bluetooth

2024-05-13 14:10:36

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ] tools: fix using too small buffers in test-runner

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Sat, 11 May 2024 13:32:07 +0300 you wrote:
> Fix compiler warning:
>
> tools/test-runner.c:309:57: error: 'sprintf' may write a terminating nul
> past the end of the destination [-Werror=format-overflow=]
> ---
> tools/test-runner.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [BlueZ] tools: fix using too small buffers in test-runner
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=24039249854e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html