2022-02-03 17:21:55

by Jeremy Kerr

[permalink] [raw]
Subject: Re: [PATCH net-next] net: don't include ndisc.h from ipv6.h

Hi Jakub,

> Nothing in ipv6.h needs ndisc.h, drop it.

Looks good, we lose the ARPHRD definitions without ndisc.h, but your
change to add if_arp.h addresses that:

> --- a/net/mctp/device.c
> +++ b/net/mctp/device.c
> @@ -6,6 +6,7 @@
>   * Copyright (c) 2021 Google
>   */
>  
> +#include <linux/if_arp.h>
>  #include <linux/if_link.h>
>  #include <linux/mctp.h>
>  #include <linux/netdevice.h>

So, for the net/mctp part:

Acked-by: Jeremy Kerr <[email protected]>

Cheers,


Jeremy