2013-12-19 12:53:15

by Sebastian Chlad

Subject: [PATCH] android/build: Adding l2test to Android.mk

Enabling l2test tool for the android target
---
android/Android.mk | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/android/Android.mk b/android/Android.mk
index ebc3219..fee2f6c 100644
--- a/android/Android.mk
+++ b/android/Android.mk
@@ -226,3 +226,27 @@ LOCAL_MODULE_TAGS := optional
LOCAL_MODULE := audio.a2dp.default

include $(BUILD_SHARED_LIBRARY)
+
+#
+# l2cap-test
+#
+
+include $(CLEAR_VARS)
+
+LOCAL_SRC_FILES := \
+ ../tools/l2test.c \
+ ../lib/bluetooth.c \
+ ../lib/hci.c \
+
+LOCAL_C_INCLUDES := \
+ $(LOCAL_PATH)/.. \
+ $(LOCAL_PATH)/../lib \
+ $(LOCAL_PATH)/../src/shared \
+
+LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
+
+LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
+LOCAL_MODULE_TAGS := eng
+LOCAL_MODULE := l2test
+
+include $(BUILD_EXECUTABLE)
--
1.8.1.2

2013-12-19 13:33:08

by Szymon Janc

Subject: Re: [PATCH] android/build: Adding l2test to Android.mk

Hi Sebastian,

> Enabling l2test tool for the android target
> ---
> android/Android.mk | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index ebc3219..fee2f6c 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -226,3 +226,27 @@ LOCAL_MODULE_TAGS := optional
> LOCAL_MODULE := audio.a2dp.default
>
> include $(BUILD_SHARED_LIBRARY)
> +
> +#
> +# l2cap-test
> +#
> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_SRC_FILES := \
> + ../tools/l2test.c \
> + ../lib/bluetooth.c \
> + ../lib/hci.c \
> +
> +LOCAL_C_INCLUDES := \
> + $(LOCAL_PATH)/.. \
> + $(LOCAL_PATH)/../lib \
> + $(LOCAL_PATH)/../src/shared \
> +
> +LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
> +
> +LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
> +LOCAL_MODULE_TAGS := eng
> +LOCAL_MODULE := l2test
> +
> +include $(BUILD_EXECUTABLE)
>

Applied (after fixing commit message), thanks.

--
BR
Szymon Janc

2013-12-19 09:33:06

by Szymon Janc

Subject: Re: [PATCH] android/build: Adding l2test to Android.mk

Hi Sebastian,

> Enabling l2test tool for the android target
> ---
> android/Android.mk | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index ebc3219..c59df7a 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -226,3 +226,31 @@ LOCAL_MODULE_TAGS := optional
> LOCAL_MODULE := audio.a2dp.default
>
> include $(BUILD_SHARED_LIBRARY)
> +
> +#
> +# l2cap-test
> +#
> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_SRC_FILES := \
> + ../tools/l2test.c \
> + ../lib/bluetooth.c \
> + ../lib/hci.c \
> +
> +lib_headers := \
> + ../lib/bluetooth.h \
> + ../lib/l2cap.h \

This lib_header is not needed, please remove it.

> +
> +LOCAL_C_INCLUDES := \
> + $(LOCAL_PATH)/.. \
> + $(LOCAL_PATH)/../lib \
> + $(LOCAL_PATH)/../src/shared \
> +
> +LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
> +
> +LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
> +LOCAL_MODULE_TAGS := eng
> +LOCAL_MODULE := l2test
> +
> +include $(BUILD_EXECUTABLE)
>

Also please don't use gerund form in commit message ie. Adding -> Add.

--
BR
Szymon Janc