2018-02-08 16:03:06

by Szymon Janc

Subject: [PATCH] adapter: Remove spurious propery change signal

There is no "Connectable" property on Adapter1 interface.
---
src/adapter.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index 50cf46b11..93e36d00d 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -535,10 +535,6 @@ static void settings_changed(struct btd_adapter *adapter, uint32_t settings)
trigger_passive_scanning(adapter);
}

- if (changed_mask & MGMT_SETTING_CONNECTABLE)
- g_dbus_emit_property_changed(dbus_conn, adapter->path,
- ADAPTER_INTERFACE, "Connectable");
-
if (changed_mask & MGMT_SETTING_DISCOVERABLE) {
g_dbus_emit_property_changed(dbus_conn, adapter->path,
ADAPTER_INTERFACE, "Discoverable");
--
2.14.3

2018-02-09 14:39:09

by Szymon Janc

Subject: Re: [PATCH] adapter: Remove spurious propery change signal

On Thursday, 8 February 2018 17:03:06 CET Szymon Janc wrote:
> There is no "Connectable" property on Adapter1 interface.
> ---
> src/adapter.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 50cf46b11..93e36d00d 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -535,10 +535,6 @@ static void settings_changed(struct btd_adapter
> *adapter, uint32_t settings) trigger_passive_scanning(adapter);
> }
>
> - if (changed_mask & MGMT_SETTING_CONNECTABLE)
> - g_dbus_emit_property_changed(dbus_conn, adapter->path,
> - ADAPTER_INTERFACE, "Connectable");
> -
> if (changed_mask & MGMT_SETTING_DISCOVERABLE) {
> g_dbus_emit_property_changed(dbus_conn, adapter->path,
> ADAPTER_INTERFACE, "Discoverable");

Applied.

--
pozdrawiam
Szymon Janc