2014-08-29 11:24:21

by Andrei Emeltchenko

Subject: [PATCH] android/health: Fix incorrect check

From: Andrei Emeltchenko <[email protected]>

"!create_mdl(channel) < 0" is always false since it returns bool
---
android/health.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/health.c b/android/health.c
index abf01b4..fb2a1e3 100644
--- a/android/health.c
+++ b/android/health.c
@@ -1949,7 +1949,7 @@ static void bt_health_connect_channel(const void *buf, uint16_t len)
goto fail;

/* create mdl if it does not exists */
- if (!channel->mdl && !create_mdl(channel) < 0)
+ if (!channel->mdl && !create_mdl(channel))
goto fail;

/* reconnect mdl if it exists */
--
1.9.1

2014-08-29 14:18:14

by Szymon Janc

Subject: Re: [PATCH] android/health: Fix incorrect check

Hi Andrei,

On Friday 29 of August 2014 14:24:21 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> "!create_mdl(channel) < 0" is always false since it returns bool
> ---
> android/health.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/health.c b/android/health.c
> index abf01b4..fb2a1e3 100644
> --- a/android/health.c
> +++ b/android/health.c
> @@ -1949,7 +1949,7 @@ static void bt_health_connect_channel(const void *buf, uint16_t len)
> goto fail;
>
> /* create mdl if it does not exists */
> - if (!channel->mdl && !create_mdl(channel) < 0)
> + if (!channel->mdl && !create_mdl(channel))
> goto fail;
>
> /* reconnect mdl if it exists */

Applied. Thanks.

--
Best regards,
Szymon Janc