2022-04-28 05:09:50

by Alexander Aring

Subject: [PATCH bluetooth-next 1/3] net: 6lowpan: remove const from scalars

The keyword const makes no sense for scalar types inside the lowpan_nhc
structure. Most compilers will ignore it so we remove the keyword from
the scalar types.

Signed-off-by: Alexander Aring <[email protected]>
---
net/6lowpan/nhc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
index 67951c40734b..2ac7da388c4d 100644
--- a/net/6lowpan/nhc.h
+++ b/net/6lowpan/nhc.h
@@ -67,11 +67,11 @@ module_exit(__nhc##_exit);
struct lowpan_nhc {
struct rb_node node;
const char *name;
- const u8 nexthdr;
- const size_t nexthdrlen;
+ u8 nexthdr;
+ size_t nexthdrlen;
u8 *id;
u8 *idmask;
- const size_t idlen;
+ size_t idlen;

void (*idsetup)(struct lowpan_nhc *nhc);
int (*uncompress)(struct sk_buff *skb, size_t needed);
--
2.31.1

2022-05-03 00:01:27

by Stefan Schmidt

Subject: Re: [PATCH bluetooth-next 1/3] net: 6lowpan: remove const from scalars

Hello.

On 28.04.22 05:05, Alexander Aring wrote:
> The keyword const makes no sense for scalar types inside the lowpan_nhc
> structure. Most compilers will ignore it so we remove the keyword from
> the scalar types.
>
> Signed-off-by: Alexander Aring <[email protected]>
> ---
> net/6lowpan/nhc.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
> index 67951c40734b..2ac7da388c4d 100644
> --- a/net/6lowpan/nhc.h
> +++ b/net/6lowpan/nhc.h
> @@ -67,11 +67,11 @@ module_exit(__nhc##_exit);
> struct lowpan_nhc {
> struct rb_node node;
> const char *name;
> - const u8 nexthdr;
> - const size_t nexthdrlen;
> + u8 nexthdr;
> + size_t nexthdrlen;
> u8 *id;
> u8 *idmask;
> - const size_t idlen;
> + size_t idlen;
>
> void (*idsetup)(struct lowpan_nhc *nhc);
> int (*uncompress)(struct sk_buff *skb, size_t needed);

Reviewed-by: Stefan Schmidt <[email protected]>

regards
Stefan Schmidt

2022-05-04 04:27:48

by Jukka Rissanen

Subject: Re: [PATCH bluetooth-next 1/3] net: 6lowpan: remove const from scalars

On Wed, 2022-04-27 at 23:05 -0400, Alexander Aring wrote:
> The keyword const makes no sense for scalar types inside the
> lowpan_nhc
> structure. Most compilers will ignore it so we remove the keyword
> from
> the scalar types.
>
> Signed-off-by: Alexander Aring <[email protected]>
> ---
>  net/6lowpan/nhc.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
> index 67951c40734b..2ac7da388c4d 100644
> --- a/net/6lowpan/nhc.h
> +++ b/net/6lowpan/nhc.h
> @@ -67,11 +67,11 @@ module_exit(__nhc##_exit);
>  struct lowpan_nhc {
>         struct rb_node  node;
>         const char      *name;
> -       const u8        nexthdr;
> -       const size_t    nexthdrlen;
> +       u8              nexthdr;
> +       size_t          nexthdrlen;
>         u8              *id;
>         u8              *idmask;
> -       const size_t    idlen;
> +       size_t          idlen;
>  
>         void            (*idsetup)(struct lowpan_nhc *nhc);
>         int             (*uncompress)(struct sk_buff *skb, size_t
> needed);


Acked-by: Jukka Rissanen <[email protected]>


Cheers,
Jukka