2008-12-01 22:01:05

by Andrew Morton

[permalink] [raw]
Subject: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk

From: Mario Limonciello <[email protected]>

This patch causes the BT365 to be reset when the driver is loaded.
Without it, the machine is unable to connect to other devices or to scan
for devices.

Signed-off-by: Mario Limonciello <[email protected]>
Signed-off-by: Tim Gardner <[email protected]>
Cc: Marcel Holtmann <[email protected]>
Cc: Dave Young <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---

drivers/bluetooth/btusb.c | 3 +++
1 file changed, 3 insertions(+)

diff -puN drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk drivers/bluetooth/btusb.c
--- a/drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk
+++ a/drivers/bluetooth/btusb.c
@@ -125,6 +125,9 @@ static struct usb_device_id blacklist_ta
/* Dell laptop with Broadcom chip */
{ USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },

+ /* Dell Wireless 365 */
+ { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET },
+
/* Dell Wireless 370 */
{ USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },

_


2008-12-02 00:22:19

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk

Hi Tim,

> >> This patch causes the BT365 to be reset when the driver is loaded.
> >> Without it, the machine is unable to connect to other devices or to scan
> >> for devices.
> >>
> >> Signed-off-by: Mario Limonciello <[email protected]>
> >> Signed-off-by: Tim Gardner <[email protected]>
> >> Cc: Marcel Holtmann <[email protected]>
> >> Cc: Dave Young <[email protected]>
> >> Cc: <[email protected]>
> >> Signed-off-by: Andrew Morton <[email protected]>
> >
> > NAK. I fixed this differently by making the reset quirk default.
>
> Does that mean the devices in blacklist_table that have _only_
> BTUSB_RESET should be removed? It would get rid of roughly half of the
> entries.

that has already been done. See the pull request I sent to Dave.

Regards

Marcel



2008-12-02 00:12:25

by Tim Gardner

[permalink] [raw]
Subject: Re: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk

Marcel Holtmann wrote:
> Hi Andrew,
>
>> This patch causes the BT365 to be reset when the driver is loaded.
>> Without it, the machine is unable to connect to other devices or to scan
>> for devices.
>>
>> Signed-off-by: Mario Limonciello <[email protected]>
>> Signed-off-by: Tim Gardner <[email protected]>
>> Cc: Marcel Holtmann <[email protected]>
>> Cc: Dave Young <[email protected]>
>> Cc: <[email protected]>
>> Signed-off-by: Andrew Morton <[email protected]>
>
> NAK. I fixed this differently by making the reset quirk default.
>
> Regards
>
> Marcel
>
>

Does that mean the devices in blacklist_table that have _only_
BTUSB_RESET should be removed? It would get rid of roughly half of the
entries.

rtg
--
Tim Gardner [email protected]

2008-12-01 22:03:50

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk

Hi Andrew,

> This patch causes the BT365 to be reset when the driver is loaded.
> Without it, the machine is unable to connect to other devices or to scan
> for devices.
>
> Signed-off-by: Mario Limonciello <[email protected]>
> Signed-off-by: Tim Gardner <[email protected]>
> Cc: Marcel Holtmann <[email protected]>
> Cc: Dave Young <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>

NAK. I fixed this differently by making the reset quirk default.

Regards

Marcel