Hello all,
The attached patch improves performance of sbcenc utility. This is not very
useful in general and does not improve the SBC codec itself. But when using
sbcenc utility for benchmarking, an extra unneeded overhead skews the results
a bit and this might be worth fixing.
Before patch:
real 0m14.984s
user 0m12.981s
sys 0m1.924s
After patch:
real 0m12.279s
user 0m11.865s
sys 0m0.360s
Christian, you fixed some bugs in sbcenc a bit earlier. Could you please
also check if all your testcases also work fine with this new patch applied
and it does not break anything?
--
Best regards,
Siarhei Siamashka
Hi Siarhei,
> > > The attached patch improves performance of sbcenc utility. This is not
> > > very useful in general and does not improve the SBC codec itself. But
> > > when using sbcenc utility for benchmarking, an extra unneeded overhead
> > > skews the results a bit and this might be worth fixing.
> > >
> > > Before patch:
> > >
> > > real 0m14.984s
> > > user 0m12.981s
> > > sys 0m1.924s
> > >
> > > After patch:
> > >
> > > real 0m12.279s
> > > user 0m11.865s
> > > sys 0m0.360s
> > >
> > >
> > > Christian, you fixed some bugs in sbcenc a bit earlier. Could you please
> > > also check if all your testcases also work fine with this new patch
> > > applied and it does not break anything?
> >
> > patch has been applied to make testing easier. Send fixes if it breaks
> > something.
>
> Well, appears that it really broke something. I forgot to update the part of
> code which handled non 24 byte headers. A fix is attached. Now it should
> work fine in all cases.
patch has been applied. Thanks.
Regards
Marcel
On Sunday 18 January 2009 17:15:44 ext Marcel Holtmann wrote:
> Hi Siarhei,
>
> > The attached patch improves performance of sbcenc utility. This is not
> > very useful in general and does not improve the SBC codec itself. But
> > when using sbcenc utility for benchmarking, an extra unneeded overhead
> > skews the results a bit and this might be worth fixing.
> >
> > Before patch:
> >
> > real 0m14.984s
> > user 0m12.981s
> > sys 0m1.924s
> >
> > After patch:
> >
> > real 0m12.279s
> > user 0m11.865s
> > sys 0m0.360s
> >
> >
> > Christian, you fixed some bugs in sbcenc a bit earlier. Could you please
> > also check if all your testcases also work fine with this new patch
> > applied and it does not break anything?
>
> patch has been applied to make testing easier. Send fixes if it breaks
> something.
Well, appears that it really broke something. I forgot to update the part of
code which handled non 24 byte headers. A fix is attached. Now it should
work fine in all cases.
Best regards,
Siarhei Siamashka
Hi Siarhei,
> The attached patch improves performance of sbcenc utility. This is not very
> useful in general and does not improve the SBC codec itself. But when using
> sbcenc utility for benchmarking, an extra unneeded overhead skews the results
> a bit and this might be worth fixing.
>
> Before patch:
>
> real 0m14.984s
> user 0m12.981s
> sys 0m1.924s
>
> After patch:
>
> real 0m12.279s
> user 0m11.865s
> sys 0m0.360s
>
>
> Christian, you fixed some bugs in sbcenc a bit earlier. Could you please
> also check if all your testcases also work fine with this new patch applied
> and it does not break anything?
patch has been applied to make testing easier. Send fixes if it breaks
something.
Regards
Marcel