2010-08-09 11:17:03

by Radoslaw Jablonski

Subject: [PATCH 1/2] Fix multiple phone numbers problem in vcard-listing

This fixes displaying problem in vcard-listing when contact had multiple
home or work phone set(one contact was displayed more than one time in
vcard-listing. Now query is changed and additional entries are omitted.
---
plugins/phonebook-tracker.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
index 41d7fde..f2b9649 100644
--- a/plugins/phonebook-tracker.c
+++ b/plugins/phonebook-tracker.c
@@ -76,7 +76,7 @@
"?c nco:hasAffiliation ?a . " \
"?a nco:hasPhoneNumber ?h . " \
"} " \
- "}"
+ "} GROUP BY ?c"

#define MISSED_CALLS_QUERY \
"SELECT nco:phoneNumber(?h) nco:fullname(?c) " \
--
1.7.0.4

2010-08-09 13:55:18

by Johan Hedberg

Subject: Re: [PATCH 1/2] Fix multiple phone numbers problem in vcard-listing

Hi Radek,

On Mon, Aug 09, 2010, Radoslaw Jablonski wrote:
> This fixes displaying problem in vcard-listing when contact had multiple
> home or work phone set(one contact was displayed more than one time in
> vcard-listing. Now query is changed and additional entries are omitted.
> ---
> plugins/phonebook-tracker.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
> index 41d7fde..f2b9649 100644
> --- a/plugins/phonebook-tracker.c
> +++ b/plugins/phonebook-tracker.c
> @@ -76,7 +76,7 @@
> "?c nco:hasAffiliation ?a . " \
> "?a nco:hasPhoneNumber ?h . " \
> "} " \
> - "}"
> + "} GROUP BY ?c"
>
> #define MISSED_CALLS_QUERY \
> "SELECT nco:phoneNumber(?h) nco:fullname(?c) " \

This patch is now upstream. Thanks.

Johan