2011-07-18 11:01:14

by Szymon Janc

[permalink] [raw]
Subject: [PATCH] Fix compilation with --disable-sap and glib < 2.28

---
audio/telephony-maemo6.c | 3 +++
audio/telephony-ofono.c | 3 +++
2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
index 14d1ead..4430cc1 100644
--- a/audio/telephony-maemo6.c
+++ b/audio/telephony-maemo6.c
@@ -36,6 +36,9 @@
#include <dbus/dbus.h>
#include <gdbus.h>

+#include <bluetooth/sdp.h>
+
+#include "glib-helper.h"
#include "log.h"
#include "telephony.h"
#include "error.h"
diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
index e72734c..26815cf 100644
--- a/audio/telephony-ofono.c
+++ b/audio/telephony-ofono.c
@@ -35,6 +35,9 @@
#include <dbus/dbus.h>
#include <gdbus.h>

+#include <bluetooth/sdp.h>
+
+#include "glib-helper.h"
#include "log.h"
#include "telephony.h"

--
on behalf of ST-Ericsson



2011-07-27 20:56:34

by Mike Brudevold

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation with --disable-sap and glib < 2.28

On Wed, Jul 27, 2011 at 3:48 PM, Anderson Lizardo
<[email protected]> wrote:
> Hi Mike,
>
> On Wed, Jul 27, 2011 at 5:05 PM, Mike <[email protected]> wrote:
>>> +#include <bluetooth/sdp.h>
>>
>> I must be missing something, because I'm trying to compile from git
>> (d7f192a) and I get an error "audio/telephony-ofono.c:38: fatal error:
>> bluetooth/sdp.h: No such file or directory". ?I was previously
>> compiling bluez 4.94 just fine. ?Ideas?
>
> Try applying the patch from this email:
>
> http://article.gmane.org/gmane.linux.bluez.kernel/14625

That fixes it! Thanks!

2011-07-27 20:48:19

by Anderson Lizardo

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation with --disable-sap and glib < 2.28

Hi Mike,

On Wed, Jul 27, 2011 at 5:05 PM, Mike <[email protected]> wrote:
>> +#include <bluetooth/sdp.h>
>
> I must be missing something, because I'm trying to compile from git
> (d7f192a) and I get an error "audio/telephony-ofono.c:38: fatal error:
> bluetooth/sdp.h: No such file or directory". ?I was previously
> compiling bluez 4.94 just fine. ?Ideas?

Try applying the patch from this email:

http://article.gmane.org/gmane.linux.bluez.kernel/14625

Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

2011-07-27 20:05:43

by Mike Brudevold

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation with --disable-sap and glib < 2.28

> +#include <bluetooth/sdp.h>

I must be missing something, because I'm trying to compile from git
(d7f192a) and I get an error "audio/telephony-ofono.c:38: fatal error:
bluetooth/sdp.h: No such file or directory". I was previously
compiling bluez 4.94 just fine. Ideas?

Mike

2011-07-19 06:04:27

by Szymon Janc

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation with --disable-sap and glib < 2.28

> Hi Szymon,

Hi,

> Thanks, the patch has been upstream (after I rewrote the commit message
> since I don't see how this has anything to do with SAP).

I added sap in commit message because build failure was triggered by
./bootstrap-configure --disable-sap (now sure why though:)

--
BR
Szymon Janc

2011-07-18 21:13:27

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation with --disable-sap and glib < 2.28

Hi Szymon,

On Mon, Jul 18, 2011, Szymon Janc wrote:
> ---
> audio/telephony-maemo6.c | 3 +++
> audio/telephony-ofono.c | 3 +++
> 2 files changed, 6 insertions(+), 0 deletions(-)

Thanks, the patch has been upstream (after I rewrote the commit message
since I don't see how this has anything to do with SAP).

Johan