2011-08-08 14:48:47

by Lucas De Marchi

Subject: [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue

According to AVRCP spec there's no player id in response.
---
parser/avrcp.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/parser/avrcp.c b/parser/avrcp.c
index 485bb55..f8e4443 100644
--- a/parser/avrcp.c
+++ b/parser/avrcp.c
@@ -612,7 +612,7 @@ response:
printf("ValueCount: 0x%02x\n", num);

for (; num > 0; num--) {
- uint8_t attr, player, value;
+ uint8_t attr, value;

p_indent(level, frm);

@@ -621,11 +621,6 @@ response:

p_indent(level, frm);

- player = get_u8(frm);
- printf("Player: 0x%02x\n", player);
-
- p_indent(level, frm);
-
value = get_u8(frm);
printf("ValueID: 0x%02x (%s)\n", value,
value2str(attr, value));
--
1.7.6

2011-08-09 07:22:12

by Johan Hedberg

Subject: Re: [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue

Hi Lucas,

On Mon, Aug 08, 2011, Lucas De Marchi wrote:
> According to AVRCP spec there's no player id in response.
> ---
> parser/avrcp.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)

Applied. Thanks.

Feel free to tag hcidump patches with [PATCH hcidump] in the future.

Johan

2011-08-08 19:21:56

by Luiz Augusto von Dentz

Subject: Re: [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue

Hi Lucas,

On Mon, Aug 8, 2011 at 5:48 PM, Lucas De Marchi
<[email protected]> wrote:
> According to AVRCP spec there's no player id in response.
> ---
> ?parser/avrcp.c | ? ?7 +------
> ?1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/parser/avrcp.c b/parser/avrcp.c
> index 485bb55..f8e4443 100644
> --- a/parser/avrcp.c
> +++ b/parser/avrcp.c
> @@ -612,7 +612,7 @@ response:
> ? ? ? ?printf("ValueCount: 0x%02x\n", num);
>
> ? ? ? ?for (; num > 0; num--) {
> - ? ? ? ? ? ? ? uint8_t attr, player, value;
> + ? ? ? ? ? ? ? uint8_t attr, value;
>
> ? ? ? ? ? ? ? ?p_indent(level, frm);
>
> @@ -621,11 +621,6 @@ response:
>
> ? ? ? ? ? ? ? ?p_indent(level, frm);
>
> - ? ? ? ? ? ? ? player = get_u8(frm);
> - ? ? ? ? ? ? ? printf("Player: 0x%02x\n", player);
> -
> - ? ? ? ? ? ? ? p_indent(level, frm);
> -
> ? ? ? ? ? ? ? ?value = get_u8(frm);
> ? ? ? ? ? ? ? ?printf("ValueID: 0x%02x (%s)\n", value,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?value2str(attr, value));
> --
> 1.7.6

Nice catch, I guess I got confused because of the page break.



--
Luiz Augusto von Dentz