2011-08-05 14:52:01

by Peter Hurley

Subject: [PATCH 4/4] Bluetooth: hidp: Don't release device ref if never held

When an hidp connection is added for a boot protocol input
device, don't release a device reference that was never
acquired. The device reference is acquired when the session
is linked to the session list (which hasn't happened yet when
hidp_setup_input is called).

Signed-off-by: Peter Hurley <[email protected]>
---
net/bluetooth/hidp/core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index a859f90..fb68f34 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -844,7 +844,6 @@ static int hidp_setup_input(struct hidp_session *session,
if (err < 0) {
input_free_device(input);
session->input = NULL;
- hci_conn_put_device(session->conn);
return err;
}

--
1.7.4.1

2011-08-11 21:07:16

by Gustavo Padovan

Subject: Re: [PATCH 4/4] Bluetooth: hidp: Don't release device ref if never held

Hi Peter,

* Peter Hurley <[email protected]> [2011-08-05 10:52:01 -0400]:

> When an hidp connection is added for a boot protocol input
> device, don't release a device reference that was never
> acquired. The device reference is acquired when the session
> is linked to the session list (which hasn't happened yet when
> hidp_setup_input is called).
>
> Signed-off-by: Peter Hurley <[email protected]>
> ---
> net/bluetooth/hidp/core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)

All four patches applied. Thanks.

Gustavo