LinuxLists.cc - [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.

2011-11-23 10:03:56

Subject: [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.

2011-11-24 11:19:08

Subject: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.

From: Eran <[email protected]>

The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
and requires a firmware to be uploaded before it's usable.

Signed-off-by: Eran <[email protected]>
---
drivers/bluetooth/ath3k.c | 2 ++
drivers/bluetooth/btusb.c | 1 +
2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 106beb1..b94aae6 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {

/* Atheros AR3012 with sflash firmware*/
{ USB_DEVICE(0x0CF3, 0x3004) },
+ { USB_DEVICE(0x13d3, 0x3375) },

/* Atheros AR5BBU12 with sflash firmware */
{ USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {

/* Atheros AR3012 with sflash firmware*/
{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+ { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },

{ } /* Terminating entry */
};
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f9b7260..a64f15a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {

/* Atheros 3012 with sflash firmware */
{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+ { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },

/* Atheros AR5BBU12 with sflash firmware */
{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
--
1.7.2.5

On Wed, Nov 23, 2011 at 04:05:00PM -0300, Vinicius Costa Gomes wrote:
> Hi Eran,
>
> Just a few cosmetic comments, and a disclaimer: I don't have any
> idea why it seems that every new Atheros device needs another
> entry in those tables.
>
> Apart from those minor points it looks good.
>
> On 10:03 Wed 23 Nov, eran wrote:
> > From: Eran <[email protected]>
>
> Keep the subject line shorter, under 60 or so characters, i.e. remove
> the part between parentheses. And prefix your subject with "Bluetooth:".
>
> >
> > The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
>
> Please break the comment at 70 or so characters.
>
> >
> > Signed-off-by: Eran <[email protected]>
> > ---
> > drivers/bluetooth/ath3k.c | 2 ++
> > drivers/bluetooth/btusb.c | 1 +
> > 2 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > index 106beb1..b94aae6 100644
> > --- a/drivers/bluetooth/ath3k.c
> > +++ b/drivers/bluetooth/ath3k.c
> > @@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
> >
> > /* Atheros AR3012 with sflash firmware*/
> > { USB_DEVICE(0x0CF3, 0x3004) },
> > + { USB_DEVICE(0x13d3, 0x3375) },
> >
> > /* Atheros AR5BBU12 with sflash firmware */
> > { USB_DEVICE(0x0489, 0xE02C) },
> > @@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
> >
> > /* Atheros AR3012 with sflash firmware*/
> > { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> > + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> >
> > { } /* Terminating entry */
> > };
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index f9b7260..a64f15a 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
> >
> > /* Atheros 3012 with sflash firmware */
> > { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> > + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> >
> > /* Atheros AR5BBU12 with sflash firmware */
> > { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
> > --
> > 1.7.2.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Cheers,
> --
> Vinicius

2011-11-23 19:05:00

by Vinicius Costa Gomes

[permalink] [raw]

Subject: Re: [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.

Hi Eran,

Just a few cosmetic comments, and a disclaimer: I don't have any
idea why it seems that every new Atheros device needs another
entry in those tables.

Apart from those minor points it looks good.

On 10:03 Wed 23 Nov, eran wrote:
> From: Eran <[email protected]>

Keep the subject line shorter, under 60 or so characters, i.e. remove
the part between parentheses. And prefix your subject with "Bluetooth:".

>
> The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.

Please break the comment at 70 or so characters.

>
> Signed-off-by: Eran <[email protected]>
> ---
> drivers/bluetooth/ath3k.c | 2 ++
> drivers/bluetooth/btusb.c | 1 +
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index 106beb1..b94aae6 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
>
> /* Atheros AR3012 with sflash firmware*/
> { USB_DEVICE(0x0CF3, 0x3004) },
> + { USB_DEVICE(0x13d3, 0x3375) },
>
> /* Atheros AR5BBU12 with sflash firmware */
> { USB_DEVICE(0x0489, 0xE02C) },
> @@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
>
> /* Atheros AR3012 with sflash firmware*/
> { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
>
> { } /* Terminating entry */
> };
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index f9b7260..a64f15a 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
>
> /* Atheros 3012 with sflash firmware */
> { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> + { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
>
> /* Atheros AR5BBU12 with sflash firmware */
> { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers,
--
Vinicius

2011-12-05 22:15:29

by eran

[permalink] [raw]

Subject: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.

From: Eran <[email protected]>

The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
and requires a firmware to be uploaded before it's usable.

output of usb-devices for this module:
T: Bus=01 Lev=02 Prnt=02 Port=07 Cnt=03 Dev#= 6 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=13d3 ProdID=3375 Rev=00.02
S: Manufacturer=Atheros Communications
S: Product=Bluetooth USB Host Controller
S: SerialNumber=Alaska Day 2006
C: #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

Signed-off-by: Eran <[email protected]>
---
drivers/bluetooth/ath3k.c | 2 ++
drivers/bluetooth/btusb.c | 1 +
2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 106beb1..b94aae6 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {

/* Atheros AR3012 with sflash firmware*/
{ USB_DEVICE(0x0CF3, 0x3004) },
+ { USB_DEVICE(0x13d3, 0x3375) },

/* Atheros AR5BBU12 with sflash firmware */
{ USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {

/* Atheros AR3012 with sflash firmware*/
{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+ { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },

{ } /* Terminating entry */
};
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f9b7260..a64f15a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {

/* Atheros 3012 with sflash firmware */
{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+ { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },

/* Atheros AR5BBU12 with sflash firmware */
{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
--
1.7.2.5

2011-12-02 11:15:11

by Gustavo Padovan

[permalink] [raw]

Subject: Re: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.

Hi Eran,

* eran <[email protected]> [2011-11-24 11:19:08 +0000]:

> From: Eran <[email protected]>
>
> The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
> and requires a firmware to be uploaded before it's usable.
>
> Signed-off-by: Eran <[email protected]>
> ---
> drivers/bluetooth/ath3k.c | 2 ++
> drivers/bluetooth/btusb.c | 1 +
> 2 files changed, 3 insertions(+), 0 deletions(-)

Please also add the output of the usb-devices scripts related to this device,
then you can prove in the commit message that your change is really needed.

Gustavo

2012-01-17 11:04:52

by Michal Labedzki

[permalink] [raw]

Subject: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.

I verified this patch. It is works and seems to be correct.
Please apply it. Tested on UX21 with/without patch and with/without
firmware (from latest linux-firmware).

2012-03-08 05:17:07

by Gustavo Padovan

[permalink] [raw]

Subject: Re: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.

Hi Eran,

* eran <[email protected]> [2011-12-05 22:15:29 +0000]:

> From: Eran <[email protected]>
>
> The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
> and requires a firmware to be uploaded before it's usable.
>
> output of usb-devices for this module:
> T: Bus=01 Lev=02 Prnt=02 Port=07 Cnt=03 Dev#= 6 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=13d3 ProdID=3375 Rev=00.02
> S: Manufacturer=Atheros Communications
> S: Product=Bluetooth USB Host Controller
> S: SerialNumber=Alaska Day 2006
> C: #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

I applied this patch now, thanks.

Gustavo