2011-12-29 16:59:44

by David Herrmann

Subject: [PATCH] Fix wiimote device_get_address to use new API

Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
patch converts the plugin to use the new API.
---
plugins/wiimote.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/wiimote.c b/plugins/wiimote.c
index fead72a..1ae638b 100644
--- a/plugins/wiimote.c
+++ b/plugins/wiimote.c
@@ -63,7 +63,7 @@ static ssize_t wii_pincb(struct btd_adapter *adapter, struct btd_device *device,
char addr[18];

adapter_get_address(adapter, &sba);
- device_get_address(device, &dba);
+ device_get_address(device, &dba, NULL);
ba2str(&dba, addr);

vendor = btd_device_get_vendor(device);
--
1.7.8.1

2011-12-30 11:06:53

by Johan Hedberg

Subject: Re: [PATCH v2] Add wiimote plugin to bootstrap-configure

Hi David,

On Thu, Dec 29, 2011, David Herrmann wrote:
> ---
> Sorry, this time without the signed-off-by line.
>
> bootstrap-configure | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Applied. Thanks.

Johan

2011-12-30 11:06:38

by Johan Hedberg

Subject: Re: [PATCH] Fix wiimote device_get_address to use new API

Hi David,

On Thu, Dec 29, 2011, David Herrmann wrote:
> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API
> for device_get_name but apparently missed fixing the call in
> plugins/wiimote.c. This patch converts the plugin to use the new API.
> ---
> plugins/wiimote.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Applied after the obvious s/get_name/get_address/ in the commit message.
Thanks.

Johan

2011-12-29 17:22:28

by David Herrmann

Subject: [PATCH v2] Add wiimote plugin to bootstrap-configure

---
Sorry, this time without the signed-off-by line.

bootstrap-configure | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap-configure b/bootstrap-configure
index 94da969..89ea156 100755
--- a/bootstrap-configure
+++ b/bootstrap-configure
@@ -34,5 +34,6 @@ fi
--enable-cups \
--enable-sap \
--enable-thermometer \
+ --enable-wiimote \
--disable-pcmcia \
--disable-datafiles $*
--
1.7.8.1

2011-12-29 17:20:21

by David Herrmann

Subject: Re: [PATCH] Fix wiimote device_get_address to use new API

On Thu, Dec 29, 2011 at 6:15 PM, Anderson Lizardo
<[email protected]> wrote:
> Hi David,
>
> On Thu, Dec 29, 2011 at 12:59 PM, David Herrmann
> <[email protected]> wrote:
>> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
>> device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
>> patch converts the plugin to use the new API.
>
> You should consider adding this plugin to bootstrap-configure, so it
> is not forgotten again. Currently it is not built by running
> "./bootstrap-configure"

Ah, I didn't know of it. I've sent a separate patch. Thanks.

2011-12-29 17:19:09

by David Herrmann

Subject: [PATCH] Add wiimote plugin to bootstrap-configure

Signed-off-by: David Herrmann <[email protected]>
---
bootstrap-configure | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap-configure b/bootstrap-configure
index 94da969..89ea156 100755
--- a/bootstrap-configure
+++ b/bootstrap-configure
@@ -34,5 +34,6 @@ fi
--enable-cups \
--enable-sap \
--enable-thermometer \
+ --enable-wiimote \
--disable-pcmcia \
--disable-datafiles $*
--
1.7.8.1

2011-12-29 17:15:12

by Anderson Lizardo

Subject: Re: [PATCH] Fix wiimote device_get_address to use new API

Hi David,

On Thu, Dec 29, 2011 at 12:59 PM, David Herrmann
<[email protected]> wrote:
> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
> device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
> patch converts the plugin to use the new API.

You should consider adding this plugin to bootstrap-configure, so it
is not forgotten again. Currently it is not built by running
"./bootstrap-configure"

Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil