2012-01-03 14:44:33

by Dan Carpenter

Subject: Bluetooth: invert locking order in connect path

Hi Gustavo,

You didn't mean to mark the function inline in 03a001948166 "Bluetooth:
invert locking order in connect path" did you? It causes a Sparse
warning.

include/net/bluetooth/l2cap.h:837:30 error: marked inline, but without
a definition

regards,
dan carpenter

2012-01-11 15:01:53

by Johan Hedberg

Subject: Re: Bluetooth: invert locking order in connect path

Hi,

On Tue, Jan 03, 2012, Gustavo Padovan wrote:
> * Dan Carpenter <[email protected]> [2012-01-03 17:44:33 +0300]:
>
> > Hi Gustavo,
> >
> > You didn't mean to mark the function inline in 03a001948166 "Bluetooth:
> > invert locking order in connect path" did you? It causes a Sparse
> > warning.
> >
> > include/net/bluetooth/l2cap.h:837:30 error: marked inline, but without
> > a definition
>
> Indeed, I'll fix it.

I didn't see the patch for this anywhere so I did it myself and got an
ack from Marcel. It's now part of my bluetooth-next tree.

Johan

2012-01-03 19:10:01

by Gustavo Padovan

Subject: Re: Bluetooth: invert locking order in connect path

Hi Dan,

* Dan Carpenter <[email protected]> [2012-01-03 17:44:33 +0300]:

> Hi Gustavo,
>
> You didn't mean to mark the function inline in 03a001948166 "Bluetooth:
> invert locking order in connect path" did you? It causes a Sparse
> warning.
>
> include/net/bluetooth/l2cap.h:837:30 error: marked inline, but without
> a definition

Indeed, I'll fix it.

Gustavo