2012-03-09 11:00:50

by Andrei Emeltchenko

Subject: [PATCH] Bluetooth: Fix extra conversion to __le32

From: Andrei Emeltchenko <[email protected]>

Value to be converted is already in __le32 format.

Signed-off-by: Andrei Emeltchenko <[email protected]>
---
net/bluetooth/mgmt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 7fcff88..97b5b6c 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -3107,7 +3107,7 @@ int mgmt_user_confirm_request(struct hci_dev *hdev, bdaddr_t *bdaddr,
bacpy(&ev.addr.bdaddr, bdaddr);
ev.addr.type = link_to_mgmt(link_type, addr_type);
ev.confirm_hint = confirm_hint;
- put_unaligned_le32(value, &ev.value);
+ ev.value = value;

return mgmt_event(MGMT_EV_USER_CONFIRM_REQUEST, hdev, &ev, sizeof(ev),
NULL);
--
1.7.9

2012-03-09 17:06:36

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: Fix extra conversion to __le32

Hi Andrei,

> Value to be converted is already in __le32 format.
>
> Signed-off-by: Andrei Emeltchenko <[email protected]>
> ---
> net/bluetooth/mgmt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 7fcff88..97b5b6c 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -3107,7 +3107,7 @@ int mgmt_user_confirm_request(struct hci_dev *hdev, bdaddr_t *bdaddr,
> bacpy(&ev.addr.bdaddr, bdaddr);
> ev.addr.type = link_to_mgmt(link_type, addr_type);
> ev.confirm_hint = confirm_hint;
> - put_unaligned_le32(value, &ev.value);
> + ev.value = value;

actually we do not need put_unaligned_le32 anyway here since the struct
itself is already __packed. So you might wanna go through the code and
fix these up as well.

Regards

Marcel

2012-03-09 12:41:28

by Gustavo Padovan

Subject: Re: [PATCH] Bluetooth: Fix extra conversion to __le32

Hi Andrei,

* Andrei Emeltchenko <[email protected]> [2012-03-09 13:00:50 +0200]:

> From: Andrei Emeltchenko <[email protected]>
>
> Value to be converted is already in __le32 format.
>
> Signed-off-by: Andrei Emeltchenko <[email protected]>
> ---
> net/bluetooth/mgmt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Gustavo