2012-04-05 04:57:21

by Hemant Gupta

Subject: [PATCH] Bluetooth: Don't set Discoverty Type while stopping Discovery

This patch prevents resetting of discovery type while stopping
discovery, which was sending wrong type information to management
interface of BlueZ when discovery failed.

Signed-off-by: Hemant Gupta <[email protected]>
---
net/bluetooth/hci_core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 286f3fc..9629645 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -386,7 +386,6 @@ void hci_discovery_set_state(struct hci_dev *hdev, int state)
case DISCOVERY_STOPPED:
if (hdev->discovery.state != DISCOVERY_STARTING)
mgmt_discovering(hdev, 0);
- hdev->discovery.type = 0;
break;
case DISCOVERY_STARTING:
break;
--
1.7.0.4

2012-04-05 10:54:14

by Johan Hedberg

Subject: Re: [PATCH] Bluetooth: Don't set Discoverty Type while stopping Discovery

Hi Hemant,

On Thu, Apr 05, 2012, Hemant Gupta wrote:
> This patch prevents resetting of discovery type while stopping
> discovery, which was sending wrong type information to management
> interface of BlueZ when discovery failed.
>
> Signed-off-by: Hemant Gupta <[email protected]>
> ---
> net/bluetooth/hci_core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)

Applied to bluetooth-next, but you really need to start using a spell
checker on your commit messages. Also, you don't necessarily need to
refer to the behavior caused to current user space since it's perfectly
possible to justify the patch without that. Furthermore, please prefix
any fixes with "Fix ...". It makes it easier to get these pulled once
applied to bluetooth.git (less explaining to do to the wireless
maintainer).

Johan