2012-07-23 21:19:04

by Andre Guedes

Subject: [PATCH] Bluetooth: Remove locking in hci_user_passkey_request_evt

This patch removes hdev locking in hci_user_passkey_request_evt
since it is not needed. mgmt_user_passkey_request simply calls
mgmt_event which does not require hdev locking at all.

Signed-off-by: Andre Guedes <[email protected]>
---
net/bluetooth/hci_event.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 41ff978..a6c509d 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -3252,12 +3252,8 @@ static void hci_user_passkey_request_evt(struct hci_dev *hdev,

BT_DBG("%s", hdev->name);

- hci_dev_lock(hdev);
-
if (test_bit(HCI_MGMT, &hdev->dev_flags))
mgmt_user_passkey_request(hdev, &ev->bdaddr, ACL_LINK, 0);
-
- hci_dev_unlock(hdev);
}

static void hci_simple_pair_complete_evt(struct hci_dev *hdev,
--
1.7.11.2

2012-07-24 23:42:05

by Gustavo Padovan

Subject: Re: [PATCH] Bluetooth: Remove locking in hci_user_passkey_request_evt

Hi Andre,

* Andre Guedes <[email protected]> [2012-07-23 18:19:04 -0300]:

> This patch removes hdev locking in hci_user_passkey_request_evt
> since it is not needed. mgmt_user_passkey_request simply calls
> mgmt_event which does not require hdev locking at all.
>
> Signed-off-by: Andre Guedes <[email protected]>
> ---
> net/bluetooth/hci_event.c | 4 ----
> 1 file changed, 4 deletions(-)

Patch has been applied to bluuetooth-next. Thanks.

Gustavo