2012-08-07 05:07:45

by Sachin Kamat

Subject: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file

module_platform_driver() makes the code simpler by eliminating module_init
and module_exit calls.

Signed-off-by: Sachin Kamat <[email protected]>
---
This patch is based on bluetooth-next tree and is compile tested.
---
drivers/bluetooth/btwilink.c | 16 +---------------
1 files changed, 1 insertions(+), 15 deletions(-)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index 4ad7b35..60abf59 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -358,21 +358,7 @@ static struct platform_driver btwilink_driver = {
},
};

-/* ------- Module Init/Exit interfaces ------ */
-static int __init btwilink_init(void)
-{
- BT_INFO("Bluetooth Driver for TI WiLink - Version %s", VERSION);
-
- return platform_driver_register(&btwilink_driver);
-}
-
-static void __exit btwilink_exit(void)
-{
- platform_driver_unregister(&btwilink_driver);
-}
-
-module_init(btwilink_init);
-module_exit(btwilink_exit);
+module_platform_driver(btwilink_driver);

/* ------ Module Info ------ */

--
1.7.4.1

2012-08-27 15:24:09

by Gustavo Padovan

Subject: Re: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file

Hi Sachin,

* Sachin Kamat <[email protected]> [2012-08-07 10:37:45 +0530]:

> module_platform_driver() makes the code simpler by eliminating module_init
> and module_exit calls.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> This patch is based on bluetooth-next tree and is compile tested.
> ---
> drivers/bluetooth/btwilink.c | 16 +---------------
> 1 files changed, 1 insertions(+), 15 deletions(-)

Patch has been applied to bluetooth-next. Thanks.

Gustavo

2012-08-23 15:16:32

by Sachin Kamat

Subject: Re: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file

Hi Gustavo,

Looks like the following patch is missed out from your tree.



On 7 August 2012 11:42, Marcel Holtmann <[email protected]> wrote:
> Hi Sachin,
>
>> module_platform_driver() makes the code simpler by eliminating module_init
>> and module_exit calls.
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
>> ---
>> This patch is based on bluetooth-next tree and is compile tested.
>> ---
>> drivers/bluetooth/btwilink.c | 16 +---------------
>> 1 files changed, 1 insertions(+), 15 deletions(-)
>
> Acked-by: Marcel Holtmann <[email protected]>
>
> Regards
>
> Marcel
>
>



--
With warm regards,
Sachin

2012-08-07 06:12:41

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file

Hi Sachin,

> module_platform_driver() makes the code simpler by eliminating module_init
> and module_exit calls.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> This patch is based on bluetooth-next tree and is compile tested.
> ---
> drivers/bluetooth/btwilink.c | 16 +---------------
> 1 files changed, 1 insertions(+), 15 deletions(-)

Acked-by: Marcel Holtmann <[email protected]>

Regards

Marcel