2012-10-29 17:07:36

by Syam Sidhardhan

Subject: [PATCH 4/5 v1] Bluetooth: mgmt: Use __constant when dealing with constants

__constant_cpu_to_le*() is the right go here.

Signed-off-by: Syam Sidhardhan <[email protected]>
---
v1-> Improve readability by breaking 80 chars rule.

net/bluetooth/mgmt.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b127b88..802ffc5 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -222,7 +222,7 @@ static int cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status)

hdr = (void *) skb_put(skb, sizeof(*hdr));

- hdr->opcode = cpu_to_le16(MGMT_EV_CMD_STATUS);
+ hdr->opcode = __constant_cpu_to_le16(MGMT_EV_CMD_STATUS);
hdr->index = cpu_to_le16(index);
hdr->len = cpu_to_le16(sizeof(*ev));

@@ -253,7 +253,7 @@ static int cmd_complete(struct sock *sk, u16 index, u16 cmd, u8 status,

hdr = (void *) skb_put(skb, sizeof(*hdr));

- hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);
+ hdr->opcode = __constant_cpu_to_le16(MGMT_EV_CMD_COMPLETE);
hdr->index = cpu_to_le16(index);
hdr->len = cpu_to_le16(sizeof(*ev) + rp_len);

@@ -832,7 +832,7 @@ static int mgmt_event(u16 event, struct hci_dev *hdev, void *data, u16 data_len,
if (hdev)
hdr->index = cpu_to_le16(hdev->id);
else
- hdr->index = cpu_to_le16(MGMT_INDEX_NONE);
+ hdr->index = __constant_cpu_to_le16(MGMT_INDEX_NONE);
hdr->len = cpu_to_le16(data_len);

if (data)
@@ -3570,9 +3570,9 @@ int mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
ev->addr.type = link_to_bdaddr(link_type, addr_type);
ev->rssi = rssi;
if (cfm_name)
- ev->flags |= cpu_to_le32(MGMT_DEV_FOUND_CONFIRM_NAME);
+ ev->flags |= __constant_cpu_to_le32(MGMT_DEV_FOUND_CONFIRM_NAME);
if (!ssp)
- ev->flags |= cpu_to_le32(MGMT_DEV_FOUND_LEGACY_PAIRING);
+ ev->flags |= __constant_cpu_to_le32(MGMT_DEV_FOUND_LEGACY_PAIRING);

if (eir_len > 0)
memcpy(ev->eir, eir, eir_len);
--
1.7.9.5

2012-10-31 18:27:46

by Gustavo Padovan

Subject: Re: [PATCH 4/5 v1] Bluetooth: mgmt: Use __constant when dealing with constants

Hi Syam,

* Syam Sidhardhan <[email protected]> [2012-10-29 22:37:36 +0530]:

> __constant_cpu_to_le*() is the right go here.
>
> Signed-off-by: Syam Sidhardhan <[email protected]>
> ---
> v1-> Improve readability by breaking 80 chars rule.
>
> net/bluetooth/mgmt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

Patch has been applied to bluetooth-next. Thanks

Gustavo

2012-10-29 19:11:12

by Marcel Holtmann

Subject: Re: [PATCH 4/5 v1] Bluetooth: mgmt: Use __constant when dealing with constants

Hi Syam,

> __constant_cpu_to_le*() is the right go here.
>
> Signed-off-by: Syam Sidhardhan <[email protected]>
> ---
> v1-> Improve readability by breaking 80 chars rule.
>
> net/bluetooth/mgmt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

Acked-by: Marcel Holtmann <[email protected]>

Regards

Marcel