2013-02-20 16:26:34

by Timo Müller

Subject: [PATCH] tools: btmgmt: Fix return value to return request id

From: Timo Mueller <[email protected]>

Commit 947a7477d2a2ab6a61e5a7de44fd5b7cd2ab8d9c introduced the method
send_cmd which returned the index of the adapter instead of the
request id. As a result no mgmt command could be sent to hci0, as 0
marks an invalid request id.
---
tools/btmgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index 4650876..4c6665e 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -833,7 +833,7 @@ static unsigned int send_cmd(struct mgmt *mgmt, uint16_t op, uint16_t id,
if (send_id == 0)
g_free(data);

- return id;
+ return send_id;
}

static void setting_rsp(uint16_t op, uint16_t id, uint8_t status, uint16_t len,
--
1.7.11.7

2013-02-20 18:16:03

by Johan Hedberg

Subject: Re: [PATCH] tools: btmgmt: Fix return value to return request id

Hi Timo,

On Wed, Feb 20, 2013, Timo Mueller wrote:
> Commit 947a7477d2a2ab6a61e5a7de44fd5b7cd2ab8d9c introduced the method
> send_cmd which returned the index of the adapter instead of the
> request id. As a result no mgmt command could be sent to hci0, as 0
> marks an invalid request id.
> ---
> tools/btmgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Good catch. The patch has been applied. Thanks.

Johan

2013-02-20 17:20:57

by Vinicius Costa Gomes

Subject: Re: [PATCH] tools: btmgmt: Fix return value to return request id

Hi Timo,

On 17:26 Wed 20 Feb, Timo Mueller wrote:
> From: Timo Mueller <[email protected]>
>
> Commit 947a7477d2a2ab6a61e5a7de44fd5b7cd2ab8d9c introduced the method
> send_cmd which returned the index of the adapter instead of the
> request id. As a result no mgmt command could be sent to hci0, as 0
> marks an invalid request id.
> ---

Ack.


Cheers,
--
Vinicius