2013-10-22 07:09:11

by Jukka Rissanen

Subject: [PATCH] Bluetooth: Add function name to debug prints

---
Hi,

the debug prints are quite useless without the function name.
Without this patch one sees lot of "hci0" lines which is not
very helpful.

Cheers,
Jukka

include/net/bluetooth/bluetooth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index bf2ddff..0b1eacd 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -122,7 +122,7 @@ int bt_err(const char *fmt, ...);

#define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
#define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
-#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
+#define BT_DBG(fmt, ...) pr_debug("%s():" fmt "\n", __FUNCTION__, ##__VA_ARGS__)

/* Connection and socket states */
enum {
--
1.7.11.7

2013-10-22 07:29:30

by Johan Hedberg

Subject: Re: [PATCH] Bluetooth: Add function name to debug prints

Hi Jukka,

On Tue, Oct 22, 2013, Jukka Rissanen wrote:
> the debug prints are quite useless without the function name.
> Without this patch one sees lot of "hci0" lines which is not
> very helpful.
>
> Cheers,
> Jukka
>
> include/net/bluetooth/bluetooth.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index bf2ddff..0b1eacd 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -122,7 +122,7 @@ int bt_err(const char *fmt, ...);
>
> #define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
> #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
> -#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
> +#define BT_DBG(fmt, ...) pr_debug("%s():" fmt "\n", __FUNCTION__, ##__VA_ARGS__)

This shouldn't be necessary since you can ask the function name to be
printed using standard dynamic debug control syntax, e.g:

echo "file hci_event.c +pf" > /sys/kernel/debug/dynamic_debug/control

Johan