2014-05-14 15:53:35

by Samuel Ortiz

Subject: [PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions

0466 was probably meant to be 0644, there's no reason why everyone
except root could write there.

Signed-off-by: Samuel Ortiz <[email protected]>
---
net/bluetooth/l2cap_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index a1e5bb7..dc4d301 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -7519,9 +7519,9 @@ int __init l2cap_init(void)
l2cap_debugfs = debugfs_create_file("l2cap", 0444, bt_debugfs,
NULL, &l2cap_debugfs_fops);

- debugfs_create_u16("l2cap_le_max_credits", 0466, bt_debugfs,
+ debugfs_create_u16("l2cap_le_max_credits", 0644, bt_debugfs,
&le_max_credits);
- debugfs_create_u16("l2cap_le_default_mps", 0466, bt_debugfs,
+ debugfs_create_u16("l2cap_le_default_mps", 0644, bt_debugfs,
&le_default_mps);

bt_6lowpan_init();
--
2.0.0.rc0

--
Intel Open Source Technology Centre
http://oss.intel.com/

2014-05-14 16:07:38

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions

Hi Samuel,

> 0466 was probably meant to be 0644, there's no reason why everyone
> except root could write there.
>
> Signed-off-by: Samuel Ortiz <[email protected]>
> ---
> net/bluetooth/l2cap_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth tree.

Gustavo, please make a pull request for 3.15 for this one. This is a security issue that we should address as quickly as possible.

Regards

Marcel