2017-05-08 09:39:11

by Tobias Regnery

[permalink] [raw]

Subject: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4

---

We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
CONFIG_BT_HCIUART_H4=n:

drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
...

Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
of the protocoll.

Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
Signed-off-by: Tobias Regnery <[email protected]>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index e5fd24d90b0a..35952a94875e 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
depends on PM
+ select BT_HCIUART_H4
help
Nokia H4+ is serial protocol for communication between Bluetooth
device and host. This protocol is required for Bluetooth devices
--
2.11.0

2017-05-18 12:00:12

by Marcel Holtmann

[permalink] [raw]

Subject: Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4

---

Hi Tobias,

> We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
> CONFIG_BT_HCIUART_H4=n:
>
> drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
> drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
> ...
>
> Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
> of the protocoll.
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Tobias Regnery <[email protected]>
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel

2017-05-08 18:28:33

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4

---

Hi,

On Mon, May 08, 2017 at 11:39:11AM +0200, Tobias Regnery wrote:
> We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
> CONFIG_BT_HCIUART_H4=n:
>
> drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
> drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
> ...
>
> Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
> of the protocoll.
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Tobias Regnery <[email protected]>

Reviewed-by: Sebastian Reichel <[email protected]>

-- Sebastian

> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index e5fd24d90b0a..35952a94875e 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
> depends on BT_HCIUART
> depends on BT_HCIUART_SERDEV
> depends on PM
> + select BT_HCIUART_H4
> help
> Nokia H4+ is serial protocol for communication between Bluetooth
> device and host. This protocol is required for Bluetooth devices
> --
> 2.11.0
>

---

Attachments:

(No filename) (1.19 kB)
signature.asc (833.00 B)
Download all attachments