2017-12-05 18:15:06

by Josh Boyer

[permalink] [raw]
Subject: Re: [PATCH 1/4] linux-firmware: Add firmware file for Intel Bluetooth 9560

On Thu, Nov 30, 2017 at 1:18 PM, Tedd Ho-Jeong An <[email protected]> wrote:
> From: Tedd Ho-Jeong An <[email protected]>
>
> This patch adds the firmware file for Intel Bluetooth 9560
> Also it is known as Intel JeffersonPeak (JfP).
>
> FW Build: REL0186
>
> 9560:
> BL Ver: 37 11 10 06 01 2a 34 0f 00
> FW Ver: 37 11 10 23 01 ba 2c 11 00
>
> Release Version: 20.10
> ibt-17-x-x.sfi/ddc format will be used from 4.14 kernel version. Below
> is the commit ID for driver changes.
> https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=af3715e5cef8859571cabecc71e1cd4cc5869d6a
>
> Signed-off-by: Amit K Bag <[email protected]>
> Signed-off-by: Tedd Ho-Jeong An <[email protected]>

All four patches applied and pushed out. Thanks.

josh


2017-12-06 23:07:26

by Kyle McMartin

[permalink] [raw]
Subject: Re: [PATCH 1/4] linux-firmware: Add firmware file for Intel Bluetooth 9560

On Wed, Dec 06, 2017 at 02:33:53PM -0800, Kyle McMartin wrote:
> On Tue, Dec 05, 2017 at 05:25:58PM -0500, Josh Boyer wrote:
> > Kyle, Ben, do you have any ideas on this?
> >
>
> As I mentioned on IRC, this has happened before. (I'm inclined to blame
> Intel's mail servers. ;-)
>
> The problem is with the GIT binary patch headers, which look for the
> format to be preserved, but some newlines are in the wrong place in
> Tedd's email.
>
> I'll revert and fix these up, and then work on the back log.
>
> Thanks for your help and voluteering, Josh!
>

OK, Tedd, I've applied 1-4. Can you verify that I didn't corrupt any of
them when fixing up the binary diffs?

regards, Kyle

2017-12-06 22:33:53

by Kyle McMartin

[permalink] [raw]
Subject: Re: [PATCH 1/4] linux-firmware: Add firmware file for Intel Bluetooth 9560

On Tue, Dec 05, 2017 at 05:25:58PM -0500, Josh Boyer wrote:
> Kyle, Ben, do you have any ideas on this?
>

As I mentioned on IRC, this has happened before. (I'm inclined to blame
Intel's mail servers. ;-)

The problem is with the GIT binary patch headers, which look for the
format to be preserved, but some newlines are in the wrong place in
Tedd's email.

I'll revert and fix these up, and then work on the back log.

Thanks for your help and voluteering, Josh!

--kyle

2017-12-05 22:25:58

by Josh Boyer

[permalink] [raw]
Subject: Re: [PATCH 1/4] linux-firmware: Add firmware file for Intel Bluetooth 9560

On Tue, Dec 5, 2017 at 1:15 PM, Josh Boyer <[email protected]> wrote:
> On Thu, Nov 30, 2017 at 1:18 PM, Tedd Ho-Jeong An <[email protected]> wrote:
>> From: Tedd Ho-Jeong An <[email protected]>
>>
>> This patch adds the firmware file for Intel Bluetooth 9560
>> Also it is known as Intel JeffersonPeak (JfP).
>>
>> FW Build: REL0186
>>
>> 9560:
>> BL Ver: 37 11 10 06 01 2a 34 0f 00
>> FW Ver: 37 11 10 23 01 ba 2c 11 00
>>
>> Release Version: 20.10
>> ibt-17-x-x.sfi/ddc format will be used from 4.14 kernel version. Below
>> is the commit ID for driver changes.
>> https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=af3715e5cef8859571cabecc71e1cd4cc5869d6a
>>
>> Signed-off-by: Amit K Bag <[email protected]>
>> Signed-off-by: Tedd Ho-Jeong An <[email protected]>
>
> All four patches applied and pushed out. Thanks.

Hm. So I spoke too soon on this. Thomas pointed out all the newly
added files are 0 sized. I can't figure out why this is. git-am
accepts the patch, but it doesn't look like it is writing out any of
the content to the actual files.

Kyle, Ben, do you have any ideas on this?

josh