2017-12-19 21:27:59

by Steve Brown

Subject: [PATCH] mesh: meshctl: Make composition-get argument optional

From: Steve Brown <[email protected]>

It can't be both optional and required.

[config: Target = 0100]# composition-get 0
Unable to parse optional command arguments
---
mesh/config-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mesh/config-client.c b/mesh/config-client.c
index fc6b3dc5d..f280441cc 100644
--- a/mesh/config-client.c
+++ b/mesh/config-client.c
@@ -997,7 +997,7 @@ static const struct bt_shell_menu cfg_menu = {
.entries = {
{"target", "<unicast>", cmd_set_node,
"Set target node to configure"},
- {"composition-get", "[<page_num>]", cmd_get_composition,
+ {"composition-get", "[page_num]", cmd_get_composition,
"Get Composition Data"},
{"netkey-add", "<net_idx>", cmd_add_net_key,
"Add network key"},
--
2.14.1

2017-12-20 08:54:12

by Johan Hedberg

Subject: Re: [PATCH] mesh: meshctl: Make composition-get argument optional

Hi Steve,

On Tue, Dec 19, 2017, [email protected] wrote:
> It can't be both optional and required.
>
> [config: Target = 0100]# composition-get 0
> Unable to parse optional command arguments
> ---
> mesh/config-client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

Johan