LinuxLists.cc - [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

2019-04-18 13:21:43

Subject: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
bluetooth address from dts. If the bluetooth address node is missing
from the dts we will enable it controller UNCONFIGURED state.
This patch enables the normal flow even if the BD address is missing
from the dts tree.

Signed-off-by: Balakrishna Godavarthi <[email protected]>
---
net/bluetooth/hci_core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index d6b2540ba7f8..3d9175f130b3 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1460,8 +1460,6 @@ static int hci_dev_do_open(struct hci_dev *hdev)
hdev->set_bdaddr)
ret = hdev->set_bdaddr(hdev,
&hdev->public_addr);
- else
- ret = -EADDRNOTAVAIL;
}

setup_failed:
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2019-04-23 16:35:33

by Marcel Holtmann

[permalink] [raw]

Subject: Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

Hi Balakrishna,

> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
> bluetooth address from dts. If the bluetooth address node is missing
> from the dts we will enable it controller UNCONFIGURED state.
> This patch enables the normal flow even if the BD address is missing
> from the dts tree.
>
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> net/bluetooth/hci_core.c | 2 --
> 1 file changed, 2 deletions(-)

can I get an ACK for this one?

Regards

Marcel

2019-04-24 07:04:17

by Harish Bandi

[permalink] [raw]

Subject: Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

Hi Balakrishna,

On 2019-04-23 22:05, Marcel Holtmann wrote:
> Hi Balakrishna,
>
>> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
>> bluetooth address from dts. If the bluetooth address node is missing
>> from the dts we will enable it controller UNCONFIGURED state.
>> This patch enables the normal flow even if the BD address is missing
>> from the dts tree.
>>
>> Signed-off-by: Balakrishna Godavarthi <[email protected]>
>> ---
>> net/bluetooth/hci_core.c | 2 --
>> 1 file changed, 2 deletions(-)
>
> can I get an ACK for this one?
>
> Regards
>
> Marcel

nit: it would be better if we print error message, if bd address missing
in dts.

tested 20 times with bd address missing in dts.
tested 20 times with bd address available in dts.

Tested-by: Harish Bandi <[email protected]>

Thanks,
Harish

2019-04-24 07:08:51

by Balakrishna Godavarthi

[permalink] [raw]

Subject: Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

Hi Harish,

On 2019-04-24 12:34, Harish Bandi wrote:
> Hi Balakrishna,
>
> On 2019-04-23 22:05, Marcel Holtmann wrote:
>> Hi Balakrishna,
>>
>>> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
>>> bluetooth address from dts. If the bluetooth address node is missing
>>> from the dts we will enable it controller UNCONFIGURED state.
>>> This patch enables the normal flow even if the BD address is missing
>>> from the dts tree.
>>>
>>> Signed-off-by: Balakrishna Godavarthi <[email protected]>
>>> ---
>>> net/bluetooth/hci_core.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>
>> can I get an ACK for this one?
>>
>> Regards
>>
>> Marcel
>
> nit: it would be better if we print error message, if bd address
> missing in dts.
>
> tested 20 times with bd address missing in dts.
> tested 20 times with bd address available in dts.
>
> Tested-by: Harish Bandi <[email protected]>
>
>
> Thanks,
> Harish

Thanks for testing will note this improvement and send an incremental
patch.

--
Regards
Balakrishna.

2019-04-24 07:13:33

by Marcel Holtmann

[permalink] [raw]