2019-08-08 06:08:51

by Balakrishna Godavarthi

Subject: [PATCH v1] Bluetooth: btqca: Reset download type to default

This patch will reset the download flag to default value
before retrieving the download mode type.

Signed-off-by: Balakrishna Godavarthi <[email protected]>
---
drivers/bluetooth/btqca.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 2221935fac7e..9fb247c10855 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config *config,
BT_DBG("Length\t\t : %d bytes", length);

config->dnld_mode = ROME_SKIP_EVT_NONE;
+ config->dnld_type = ROME_SKIP_EVT_NONE;

switch (config->type) {
case TLV_TYPE_PATCH:
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2019-08-08 06:21:43

by Rocky Liao

Subject: Re: [PATCH v1] Bluetooth: btqca: Reset download type to default

+Claire

On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> This patch will reset the download flag to default value
> before retrieving the download mode type.
>
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> drivers/bluetooth/btqca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
> *config,
> BT_DBG("Length\t\t : %d bytes", length);
>
> config->dnld_mode = ROME_SKIP_EVT_NONE;
> + config->dnld_type = ROME_SKIP_EVT_NONE;
>
> switch (config->type) {
> case TLV_TYPE_PATCH:

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project

2019-08-08 06:23:59

by Rocky Liao

Subject: Re: [PATCH v1] Bluetooth: btqca: Reset download type to default

On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> This patch will reset the download flag to default value
> before retrieving the download mode type.
>
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> drivers/bluetooth/btqca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
> *config,
> BT_DBG("Length\t\t : %d bytes", length);
>
> config->dnld_mode = ROME_SKIP_EVT_NONE;
> + config->dnld_type = ROME_SKIP_EVT_NONE;
>
> switch (config->type) {
> case TLV_TYPE_PATCH:

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project

Reviewed-by: Rocky Liao <[email protected]>

2019-08-08 07:23:15

by Claire Chang

Subject: Re: [PATCH v1] Bluetooth: btqca: Reset download type to default

Tested-by: Claire Chang <[email protected]>

Hi,

Please add the Fixes: tag and I will add my Reviewed-by: tag.

Thanks,
Claire

On Thu, Aug 8, 2019 at 2:21 PM Rocky Liao <[email protected]> wrote:
>
> +Claire
>
> On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> > This patch will reset the download flag to default value
> > before retrieving the download mode type.
> >
> > Signed-off-by: Balakrishna Godavarthi <[email protected]>
> > ---
> > drivers/bluetooth/btqca.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index 2221935fac7e..9fb247c10855 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
> > *config,
> > BT_DBG("Length\t\t : %d bytes", length);
> >
> > config->dnld_mode = ROME_SKIP_EVT_NONE;
> > + config->dnld_type = ROME_SKIP_EVT_NONE;
> >
> > switch (config->type) {
> > case TLV_TYPE_PATCH:
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> a Linux Foundation Collaborative Project

2019-08-08 08:58:18

by Balakrishna Godavarthi

Subject: Re: [PATCH v1] Bluetooth: btqca: Reset download type to default

Hi,

On 2019-08-08 12:51, Claire Chang wrote:
> Tested-by: Claire Chang <[email protected]>
>
> Hi,
>
> Please add the Fixes: tag and I will add my Reviewed-by: tag.
>
> Thanks,
> Claire
>
> On Thu, Aug 8, 2019 at 2:21 PM Rocky Liao <[email protected]>
> wrote:
>>
>> +Claire
>>
>> On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
>> > This patch will reset the download flag to default value
>> > before retrieving the download mode type.
>> >
>> > Signed-off-by: Balakrishna Godavarthi <[email protected]>
>> > ---
>> > drivers/bluetooth/btqca.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> > index 2221935fac7e..9fb247c10855 100644
>> > --- a/drivers/bluetooth/btqca.c
>> > +++ b/drivers/bluetooth/btqca.c
>> > @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
>> > *config,
>> > BT_DBG("Length\t\t : %d bytes", length);
>> >
>> > config->dnld_mode = ROME_SKIP_EVT_NONE;
>> > + config->dnld_type = ROME_SKIP_EVT_NONE;
>> >
>> > switch (config->type) {
>> > case TLV_TYPE_PATCH:
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project

uploaded new patch set.

--
Regards
Balakrishna.