2019-08-08 08:58:03

by Balakrishna Godavarthi

Subject: [PATCH v2] Bluetooth: btqca: Reset download type to default

This patch will reset the download flag to default value
before retrieving the download mode type.

Fixes: 32646db8cc28 ("Bluetooth: btqca: inject command complete event during fw download")
Signed-off-by: Balakrishna Godavarthi <[email protected]>
---
v2:
* add fix tag.

---
drivers/bluetooth/btqca.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 2221935fac7e..9fb247c10855 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config *config,
BT_DBG("Length\t\t : %d bytes", length);

config->dnld_mode = ROME_SKIP_EVT_NONE;
+ config->dnld_type = ROME_SKIP_EVT_NONE;

switch (config->type) {
case TLV_TYPE_PATCH:
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2019-08-08 09:12:35

by Claire Chang

Subject: Re: [PATCH v2] Bluetooth: btqca: Reset download type to default

Tested-by: Claire Chang <[email protected]>
Reviewed-by: Claire Chang <[email protected]>

Thanks!


On Thu, Aug 8, 2019 at 4:56 PM Balakrishna Godavarthi
<[email protected]> wrote:
>
> This patch will reset the download flag to default value
> before retrieving the download mode type.
>
> Fixes: 32646db8cc28 ("Bluetooth: btqca: inject command complete event during fw download")
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> v2:
> * add fix tag.
>
> ---
> drivers/bluetooth/btqca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config *config,
> BT_DBG("Length\t\t : %d bytes", length);
>
> config->dnld_mode = ROME_SKIP_EVT_NONE;
> + config->dnld_type = ROME_SKIP_EVT_NONE;
>
> switch (config->type) {
> case TLV_TYPE_PATCH:
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

2019-08-12 17:08:47

by Marcel Holtmann

Subject: Re: [PATCH v2] Bluetooth: btqca: Reset download type to default

Hi Balakrishna,

> This patch will reset the download flag to default value
> before retrieving the download mode type.
>
> Fixes: 32646db8cc28 ("Bluetooth: btqca: inject command complete event during fw download")
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> v2:
> * add fix tag.
>
> ---
> drivers/bluetooth/btqca.c | 1 +
> 1 file changed, 1 insertion(+)

patch has been applied to bluetooth-stable tree.

Regards

Marcel