Update uhid and uinput devices with lowercase addresses (to match how
kernel prints it via %pMR). Also update uinput to include the phys
attribute and correctly set the vendor/product/version during init.
---
I was just checking through udev to see if I could correlate virtual
devices created by bluez (via uhid and uinput) to the hci interface that
owns it. While doing that, I found that the printed addresses were upper
case but other addresses in udev were lower case. (i.e. udevinfo -a -p
/sys/class/net/eth0). To keep things consistent and comparable, I opted
to convert these addresses to lower case.
I was able to compare the `phys` attribute with the value in
/sys/kernel/debug/hci0/identity to figure out which virtual devices were
created for bluetooth.
For systems that don't mount debugfs, would it be a good idea to expose
the identity in sysfs? i.e. /sys/class/bluetooth/hci0/identity?
Thanks
Abhishek
lib/bluetooth.c | 7 +++++++
lib/bluetooth.h | 1 +
profiles/audio/avctp.c | 21 ++++++++++++++-------
profiles/input/device.c | 4 ++--
profiles/input/hog-lib.c | 10 ++++++++++
5 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/lib/bluetooth.c b/lib/bluetooth.c
index effc7f49d..7cba509d8 100644
--- a/lib/bluetooth.c
+++ b/lib/bluetooth.c
@@ -81,6 +81,13 @@ int ba2str(const bdaddr_t *ba, char *str)
ba->b[5], ba->b[4], ba->b[3], ba->b[2], ba->b[1], ba->b[0]);
}
+/* Match kernel's lowercase printing of mac address (%pMR) */
+int ba2strlc(const bdaddr_t *ba, char *str)
+{
+ return sprintf(str, "%2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x",
+ ba->b[5], ba->b[4], ba->b[3], ba->b[2], ba->b[1], ba->b[0]);
+}
+
int str2ba(const char *str, bdaddr_t *ba)
{
int i;
diff --git a/lib/bluetooth.h b/lib/bluetooth.h
index eb279260e..756dce164 100644
--- a/lib/bluetooth.h
+++ b/lib/bluetooth.h
@@ -325,6 +325,7 @@ void baswap(bdaddr_t *dst, const bdaddr_t *src);
bdaddr_t *strtoba(const char *str);
char *batostr(const bdaddr_t *ba);
int ba2str(const bdaddr_t *ba, char *str);
+int ba2strlc(const bdaddr_t *ba, char *str);
int str2ba(const char *str, bdaddr_t *ba);
int ba2oui(const bdaddr_t *ba, char *oui);
int bachk(const char *str);
diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
index 70a3e40b2..42136f94b 100644
--- a/profiles/audio/avctp.c
+++ b/profiles/audio/avctp.c
@@ -1161,7 +1161,8 @@ failed:
return FALSE;
}
-static int uinput_create(char *name)
+static int uinput_create(struct btd_device *device, const char *name,
+ const char *phys)
{
struct uinput_dev dev;
int fd, err, i;
@@ -1185,9 +1186,9 @@ static int uinput_create(char *name)
strncpy(dev.name, name, UINPUT_MAX_NAME_SIZE - 1);
dev.id.bustype = BUS_BLUETOOTH;
- dev.id.vendor = 0x0000;
- dev.id.product = 0x0000;
- dev.id.version = 0x0000;
+ dev.id.vendor = btd_device_get_vendor(device);
+ dev.id.product = btd_device_get_product(device);
+ dev.id.version = btd_device_get_version(device);
if (write(fd, &dev, sizeof(dev)) < 0) {
err = -errno;
@@ -1202,6 +1203,9 @@ static int uinput_create(char *name)
ioctl(fd, UI_SET_EVBIT, EV_REP);
ioctl(fd, UI_SET_EVBIT, EV_SYN);
+ /* Also set the phys */
+ ioctl(fd, UI_SET_PHYS, phys);
+
for (i = 0; key_map[i].name != NULL; i++)
ioctl(fd, UI_SET_KEYBIT, key_map[i].uinput);
@@ -1220,7 +1224,7 @@ static int uinput_create(char *name)
static void init_uinput(struct avctp *session)
{
- char address[18], name[248 + 1];
+ char address[18], phys[18], name[248 + 1];
device_get_name(session->device, name, sizeof(name));
if (g_str_equal(name, "Nokia CK-20W")) {
@@ -1230,8 +1234,11 @@ static void init_uinput(struct avctp *session)
session->key_quirks[AVC_PAUSE] |= QUIRK_NO_RELEASE;
}
- ba2str(device_get_address(session->device), address);
- session->uinput = uinput_create(address);
+ ba2strlc(device_get_address(session->device), address);
+ ba2strlc(btd_adapter_get_address(device_get_adapter(session->device)),
+ phys);
+
+ session->uinput = uinput_create(session->device, address, phys);
if (session->uinput < 0)
error("AVRCP: failed to init uinput for %s", address);
else
diff --git a/profiles/input/device.c b/profiles/input/device.c
index a711ef527..2cb3811c8 100644
--- a/profiles/input/device.c
+++ b/profiles/input/device.c
@@ -855,8 +855,8 @@ static int uhid_connadd(struct input_device *idev, struct hidp_connadd_req *req)
memset(&ev, 0, sizeof(ev));
ev.type = UHID_CREATE;
strncpy((char *) ev.u.create.name, req->name, sizeof(ev.u.create.name));
- ba2str(&idev->src, (char *) ev.u.create.phys);
- ba2str(&idev->dst, (char *) ev.u.create.uniq);
+ ba2strlc(&idev->src, (char *) ev.u.create.phys);
+ ba2strlc(&idev->dst, (char *) ev.u.create.uniq);
ev.u.create.vendor = req->vendor;
ev.u.create.product = req->product;
ev.u.create.version = req->version;
diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c
index d9ed80689..9c5c814a7 100644
--- a/profiles/input/hog-lib.c
+++ b/profiles/input/hog-lib.c
@@ -32,6 +32,7 @@
#include <stdbool.h>
#include <errno.h>
#include <unistd.h>
+#include <ctype.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
@@ -992,6 +993,15 @@ static void report_map_read_cb(guint8 status, const guint8 *pdu, guint16 plen,
BT_IO_OPT_SOURCE, ev.u.create.phys,
BT_IO_OPT_DEST, ev.u.create.uniq,
BT_IO_OPT_INVALID);
+
+ /* Phys + uniq are the same size (hw address type) */
+ for (i = 0;
+ i < (int)sizeof(ev.u.create.phys) && ev.u.create.phys[i] != 0;
+ ++i) {
+ ev.u.create.phys[i] = tolower(ev.u.create.phys[i]);
+ ev.u.create.uniq[i] = tolower(ev.u.create.uniq[i]);
+ }
+
if (gerr) {
error("Failed to connection details: %s", gerr->message);
g_error_free(gerr);
--
2.24.0.432.g9d3f5f5b63-goog
When creating the uinput device, change the name to the peer device
name. Set the peer device address to the uniq attribute instead of the
name.
The resulting uinput device will look like this:
$ udevadm info -a -p /sys/devices/virtual/input/input17
...
looking at device '/devices/virtual/input/input17':
KERNEL=="input17"
SUBSYSTEM=="input"
DRIVER==""
ATTR{inhibited}=="0"
ATTR{name}=="BeatsStudio Wireless"
ATTR{phys}=="00:00:00:6e:d0:74"
ATTR{properties}=="0"
ATTR{uniq}=="00:00:00:cc:1c:f3"
---
This change requires an accompanying change in the kernel that adds the
set uniq ioctl. The change is available here:
https://lore.kernel.org/linux-bluetooth/[email protected]/T/#u
If this change looks ok, I would like to merge it with the previous
change before merging since they're related.
profiles/audio/avctp.c | 18 +++++++++---------
src/uinput.h | 2 ++
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
index 42136f94b..05df57bd2 100644
--- a/profiles/audio/avctp.c
+++ b/profiles/audio/avctp.c
@@ -1162,7 +1162,7 @@ failed:
}
static int uinput_create(struct btd_device *device, const char *name,
- const char *phys)
+ const char *src, const char *dst)
{
struct uinput_dev dev;
int fd, err, i;
@@ -1203,8 +1203,8 @@ static int uinput_create(struct btd_device *device, const char *name,
ioctl(fd, UI_SET_EVBIT, EV_REP);
ioctl(fd, UI_SET_EVBIT, EV_SYN);
- /* Also set the phys */
- ioctl(fd, UI_SET_PHYS, phys);
+ ioctl(fd, UI_SET_PHYS, src);
+ ioctl(fd, UI_SET_UNIQ, dst);
for (i = 0; key_map[i].name != NULL; i++)
ioctl(fd, UI_SET_KEYBIT, key_map[i].uinput);
@@ -1224,7 +1224,7 @@ static int uinput_create(struct btd_device *device, const char *name,
static void init_uinput(struct avctp *session)
{
- char address[18], phys[18], name[248 + 1];
+ char dest[18], src[18], name[248 + 1];
device_get_name(session->device, name, sizeof(name));
if (g_str_equal(name, "Nokia CK-20W")) {
@@ -1234,15 +1234,15 @@ static void init_uinput(struct avctp *session)
session->key_quirks[AVC_PAUSE] |= QUIRK_NO_RELEASE;
}
- ba2strlc(device_get_address(session->device), address);
+ ba2strlc(device_get_address(session->device), dest);
ba2strlc(btd_adapter_get_address(device_get_adapter(session->device)),
- phys);
+ src);
- session->uinput = uinput_create(session->device, address, phys);
+ session->uinput = uinput_create(session->device, name, src, dest);
if (session->uinput < 0)
- error("AVRCP: failed to init uinput for %s", address);
+ error("AVRCP: failed to init uinput for %s", dest);
else
- DBG("AVRCP: uinput initialized for %s", address);
+ DBG("AVRCP: uinput initialized for %s", dest);
}
static struct avctp_queue *avctp_queue_create(struct avctp_channel *chan)
diff --git a/src/uinput.h b/src/uinput.h
index 20e0941d1..589c22528 100644
--- a/src/uinput.h
+++ b/src/uinput.h
@@ -686,6 +686,8 @@ extern "C" {
#define UI_SET_FFBIT _IOW(UINPUT_IOCTL_BASE, 107, int)
#define UI_SET_PHYS _IOW(UINPUT_IOCTL_BASE, 108, char*)
#define UI_SET_SWBIT _IOW(UINPUT_IOCTL_BASE, 109, int)
+#define UI_SET_PROPBIT _IOW(UINPUT_IOCTL_BASE, 110, int)
+#define UI_SET_UNIQ _IOW(UINPUT_IOCTL_BASE, 111, char*)
#ifndef NBITS
#define NBITS(x) ((((x) - 1) / (sizeof(long) * 8)) + 1)
--
2.24.0.432.g9d3f5f5b63-goog
Hi Abhishek,
On Wed, Nov 27, 2019 at 9:09 PM Abhishek Pandit-Subedi
<[email protected]> wrote:
>
> Update uhid and uinput devices with lowercase addresses (to match how
> kernel prints it via %pMR). Also update uinput to include the phys
> attribute and correctly set the vendor/product/version during init.
>
> ---
> I was just checking through udev to see if I could correlate virtual
> devices created by bluez (via uhid and uinput) to the hci interface that
> owns it. While doing that, I found that the printed addresses were upper
> case but other addresses in udev were lower case. (i.e. udevinfo -a -p
> /sys/class/net/eth0). To keep things consistent and comparable, I opted
> to convert these addresses to lower case.
>
> I was able to compare the `phys` attribute with the value in
> /sys/kernel/debug/hci0/identity to figure out which virtual devices were
> created for bluetooth.
>
> For systems that don't mount debugfs, would it be a good idea to expose
> the identity in sysfs? i.e. /sys/class/bluetooth/hci0/identity?
>
> Thanks
> Abhishek
>
>
> lib/bluetooth.c | 7 +++++++
> lib/bluetooth.h | 1 +
> profiles/audio/avctp.c | 21 ++++++++++++++-------
> profiles/input/device.c | 4 ++--
> profiles/input/hog-lib.c | 10 ++++++++++
> 5 files changed, 34 insertions(+), 9 deletions(-)
>
> diff --git a/lib/bluetooth.c b/lib/bluetooth.c
> index effc7f49d..7cba509d8 100644
> --- a/lib/bluetooth.c
> +++ b/lib/bluetooth.c
> @@ -81,6 +81,13 @@ int ba2str(const bdaddr_t *ba, char *str)
> ba->b[5], ba->b[4], ba->b[3], ba->b[2], ba->b[1], ba->b[0]);
> }
>
> +/* Match kernel's lowercase printing of mac address (%pMR) */
> +int ba2strlc(const bdaddr_t *ba, char *str)
> +{
> + return sprintf(str, "%2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x",
> + ba->b[5], ba->b[4], ba->b[3], ba->b[2], ba->b[1], ba->b[0]);
> +}
Lets split this change into it own patch.
> int str2ba(const char *str, bdaddr_t *ba)
> {
> int i;
> diff --git a/lib/bluetooth.h b/lib/bluetooth.h
> index eb279260e..756dce164 100644
> --- a/lib/bluetooth.h
> +++ b/lib/bluetooth.h
> @@ -325,6 +325,7 @@ void baswap(bdaddr_t *dst, const bdaddr_t *src);
> bdaddr_t *strtoba(const char *str);
> char *batostr(const bdaddr_t *ba);
> int ba2str(const bdaddr_t *ba, char *str);
> +int ba2strlc(const bdaddr_t *ba, char *str);
> int str2ba(const char *str, bdaddr_t *ba);
> int ba2oui(const bdaddr_t *ba, char *oui);
> int bachk(const char *str);
> diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
> index 70a3e40b2..42136f94b 100644
> --- a/profiles/audio/avctp.c
> +++ b/profiles/audio/avctp.c
> @@ -1161,7 +1161,8 @@ failed:
> return FALSE;
> }
We might as well put these helpers into a mini library like we did
with uhid, but Im fine leaving it for later if you don't want to do as
part of this set.
> -static int uinput_create(char *name)
> +static int uinput_create(struct btd_device *device, const char *name,
> + const char *phys)
> {
> struct uinput_dev dev;
> int fd, err, i;
> @@ -1185,9 +1186,9 @@ static int uinput_create(char *name)
> strncpy(dev.name, name, UINPUT_MAX_NAME_SIZE - 1);
>
> dev.id.bustype = BUS_BLUETOOTH;
> - dev.id.vendor = 0x0000;
> - dev.id.product = 0x0000;
> - dev.id.version = 0x0000;
> + dev.id.vendor = btd_device_get_vendor(device);
> + dev.id.product = btd_device_get_product(device);
> + dev.id.version = btd_device_get_version(device);
>
> if (write(fd, &dev, sizeof(dev)) < 0) {
> err = -errno;
> @@ -1202,6 +1203,9 @@ static int uinput_create(char *name)
> ioctl(fd, UI_SET_EVBIT, EV_REP);
> ioctl(fd, UI_SET_EVBIT, EV_SYN);
>
> + /* Also set the phys */
> + ioctl(fd, UI_SET_PHYS, phys);
> +
> for (i = 0; key_map[i].name != NULL; i++)
> ioctl(fd, UI_SET_KEYBIT, key_map[i].uinput);
>
> @@ -1220,7 +1224,7 @@ static int uinput_create(char *name)
>
> static void init_uinput(struct avctp *session)
> {
> - char address[18], name[248 + 1];
> + char address[18], phys[18], name[248 + 1];
>
> device_get_name(session->device, name, sizeof(name));
> if (g_str_equal(name, "Nokia CK-20W")) {
> @@ -1230,8 +1234,11 @@ static void init_uinput(struct avctp *session)
> session->key_quirks[AVC_PAUSE] |= QUIRK_NO_RELEASE;
> }
>
> - ba2str(device_get_address(session->device), address);
> - session->uinput = uinput_create(address);
> + ba2strlc(device_get_address(session->device), address);
> + ba2strlc(btd_adapter_get_address(device_get_adapter(session->device)),
> + phys);
> +
> + session->uinput = uinput_create(session->device, address, phys);
You could have moved the code related to address and phys directly
into uinput_create since you are passing the device it could self
generate these.
> if (session->uinput < 0)
> error("AVRCP: failed to init uinput for %s", address);
> else
> diff --git a/profiles/input/device.c b/profiles/input/device.c
> index a711ef527..2cb3811c8 100644
> --- a/profiles/input/device.c
> +++ b/profiles/input/device.c
> @@ -855,8 +855,8 @@ static int uhid_connadd(struct input_device *idev, struct hidp_connadd_req *req)
> memset(&ev, 0, sizeof(ev));
> ev.type = UHID_CREATE;
> strncpy((char *) ev.u.create.name, req->name, sizeof(ev.u.create.name));
> - ba2str(&idev->src, (char *) ev.u.create.phys);
> - ba2str(&idev->dst, (char *) ev.u.create.uniq);
> + ba2strlc(&idev->src, (char *) ev.u.create.phys);
> + ba2strlc(&idev->dst, (char *) ev.u.create.uniq);
> ev.u.create.vendor = req->vendor;
> ev.u.create.product = req->product;
> ev.u.create.version = req->version;
> diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c
> index d9ed80689..9c5c814a7 100644
> --- a/profiles/input/hog-lib.c
> +++ b/profiles/input/hog-lib.c
> @@ -32,6 +32,7 @@
> #include <stdbool.h>
> #include <errno.h>
> #include <unistd.h>
> +#include <ctype.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <fcntl.h>
> @@ -992,6 +993,15 @@ static void report_map_read_cb(guint8 status, const guint8 *pdu, guint16 plen,
> BT_IO_OPT_SOURCE, ev.u.create.phys,
> BT_IO_OPT_DEST, ev.u.create.uniq,
> BT_IO_OPT_INVALID);
> +
> + /* Phys + uniq are the same size (hw address type) */
> + for (i = 0;
> + i < (int)sizeof(ev.u.create.phys) && ev.u.create.phys[i] != 0;
> + ++i) {
> + ev.u.create.phys[i] = tolower(ev.u.create.phys[i]);
> + ev.u.create.uniq[i] = tolower(ev.u.create.uniq[i]);
> + }
> +
> if (gerr) {
> error("Failed to connection details: %s", gerr->message);
> g_error_free(gerr);
> --
> 2.24.0.432.g9d3f5f5b63-goog
>
--
Luiz Augusto von Dentz
Hi Abhishek,
On Wed, Nov 27, 2019 at 9:09 PM Abhishek Pandit-Subedi
<[email protected]> wrote:
>
> When creating the uinput device, change the name to the peer device
> name. Set the peer device address to the uniq attribute instead of the
> name.
>
> The resulting uinput device will look like this:
>
> $ udevadm info -a -p /sys/devices/virtual/input/input17
> ...
> looking at device '/devices/virtual/input/input17':
> KERNEL=="input17"
> SUBSYSTEM=="input"
> DRIVER==""
> ATTR{inhibited}=="0"
> ATTR{name}=="BeatsStudio Wireless"
> ATTR{phys}=="00:00:00:6e:d0:74"
> ATTR{properties}=="0"
> ATTR{uniq}=="00:00:00:cc:1c:f3"
>
> ---
>
> This change requires an accompanying change in the kernel that adds the
> set uniq ioctl. The change is available here:
>
> https://lore.kernel.org/linux-bluetooth/[email protected]/T/#u
>
> If this change looks ok, I would like to merge it with the previous
> change before merging since they're related.
I would split the UNIQ handling just in case it causes a problems in
some platform so we can easily revert, Im fine merging other parts
though.
>
> profiles/audio/avctp.c | 18 +++++++++---------
> src/uinput.h | 2 ++
> 2 files changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
> index 42136f94b..05df57bd2 100644
> --- a/profiles/audio/avctp.c
> +++ b/profiles/audio/avctp.c
> @@ -1162,7 +1162,7 @@ failed:
> }
>
> static int uinput_create(struct btd_device *device, const char *name,
> - const char *phys)
> + const char *src, const char *dst)
> {
> struct uinput_dev dev;
> int fd, err, i;
> @@ -1203,8 +1203,8 @@ static int uinput_create(struct btd_device *device, const char *name,
> ioctl(fd, UI_SET_EVBIT, EV_REP);
> ioctl(fd, UI_SET_EVBIT, EV_SYN);
>
> - /* Also set the phys */
> - ioctl(fd, UI_SET_PHYS, phys);
> + ioctl(fd, UI_SET_PHYS, src);
> + ioctl(fd, UI_SET_UNIQ, dst);
>
> for (i = 0; key_map[i].name != NULL; i++)
> ioctl(fd, UI_SET_KEYBIT, key_map[i].uinput);
> @@ -1224,7 +1224,7 @@ static int uinput_create(struct btd_device *device, const char *name,
>
> static void init_uinput(struct avctp *session)
> {
> - char address[18], phys[18], name[248 + 1];
> + char dest[18], src[18], name[248 + 1];
>
> device_get_name(session->device, name, sizeof(name));
> if (g_str_equal(name, "Nokia CK-20W")) {
> @@ -1234,15 +1234,15 @@ static void init_uinput(struct avctp *session)
> session->key_quirks[AVC_PAUSE] |= QUIRK_NO_RELEASE;
> }
>
> - ba2strlc(device_get_address(session->device), address);
> + ba2strlc(device_get_address(session->device), dest);
> ba2strlc(btd_adapter_get_address(device_get_adapter(session->device)),
> - phys);
> + src);
>
> - session->uinput = uinput_create(session->device, address, phys);
> + session->uinput = uinput_create(session->device, name, src, dest);
> if (session->uinput < 0)
> - error("AVRCP: failed to init uinput for %s", address);
> + error("AVRCP: failed to init uinput for %s", dest);
> else
> - DBG("AVRCP: uinput initialized for %s", address);
> + DBG("AVRCP: uinput initialized for %s", dest);
> }
>
> static struct avctp_queue *avctp_queue_create(struct avctp_channel *chan)
> diff --git a/src/uinput.h b/src/uinput.h
> index 20e0941d1..589c22528 100644
> --- a/src/uinput.h
> +++ b/src/uinput.h
> @@ -686,6 +686,8 @@ extern "C" {
> #define UI_SET_FFBIT _IOW(UINPUT_IOCTL_BASE, 107, int)
> #define UI_SET_PHYS _IOW(UINPUT_IOCTL_BASE, 108, char*)
> #define UI_SET_SWBIT _IOW(UINPUT_IOCTL_BASE, 109, int)
> +#define UI_SET_PROPBIT _IOW(UINPUT_IOCTL_BASE, 110, int)
> +#define UI_SET_UNIQ _IOW(UINPUT_IOCTL_BASE, 111, char*)
>
> #ifndef NBITS
> #define NBITS(x) ((((x) - 1) / (sizeof(long) * 8)) + 1)
> --
> 2.24.0.432.g9d3f5f5b63-goog
>
--
Luiz Augusto von Dentz
On Wednesday 27 November 2019 11:09:15 Abhishek Pandit-Subedi wrote:
> When creating the uinput device, change the name to the peer device
> name. Set the peer device address to the uniq attribute instead of the
> name.
>
> The resulting uinput device will look like this:
>
> $ udevadm info -a -p /sys/devices/virtual/input/input17
> ...
> looking at device '/devices/virtual/input/input17':
> KERNEL=="input17"
> SUBSYSTEM=="input"
> DRIVER==""
> ATTR{inhibited}=="0"
> ATTR{name}=="BeatsStudio Wireless"
Hello, as you already wrote in different thread, could you add
" (AVCTP)" suffix to name to indicate used bluetooth profile?
> ATTR{phys}=="00:00:00:6e:d0:74"
> ATTR{properties}=="0"
> ATTR{uniq}=="00:00:00:cc:1c:f3"
>
> ---
>
> This change requires an accompanying change in the kernel that adds the
> set uniq ioctl. The change is available here:
>
> https://lore.kernel.org/linux-bluetooth/[email protected]/T/#u
>
> If this change looks ok, I would like to merge it with the previous
> change before merging since they're related.
>
>
> profiles/audio/avctp.c | 18 +++++++++---------
> src/uinput.h | 2 ++
> 2 files changed, 11 insertions(+), 9 deletions(-)
--
Pali Rohár
[email protected]