2020-01-08 21:51:48

by Michał Lowas-Rzechonek

Subject: [PATCH BlueZ] mesh: Fix BeaconFlags property type

This property is an uint8, not a boolean.

---
mesh/node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mesh/node.c b/mesh/node.c
index 032216774..13d4d3418 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -2358,7 +2358,7 @@ static void setup_node_interface(struct l_dbus_interface *iface)
l_dbus_interface_property(iface, "Features", 0, "a{sv}", features_getter,
NULL);
l_dbus_interface_property(iface, "Beacon", 0, "b", beacon_getter, NULL);
- l_dbus_interface_property(iface, "BeaconFlags", 0, "b",
+ l_dbus_interface_property(iface, "BeaconFlags", 0, "y",
beaconflags_getter, NULL);
l_dbus_interface_property(iface, "IvIndex", 0, "u", ivindex_getter,
NULL);
--
2.23.0

2020-01-08 22:05:28

by Gix, Brian

Subject: Re: [PATCH BlueZ] mesh: Fix BeaconFlags property type

Applied
On Wed, 2020-01-08 at 22:51 +0100, Michał Lowas-Rzechonek wrote:
> This property is an uint8, not a boolean.
>
> ---
> mesh/node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mesh/node.c b/mesh/node.c
> index 032216774..13d4d3418 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -2358,7 +2358,7 @@ static void setup_node_interface(struct l_dbus_interface *iface)
> l_dbus_interface_property(iface, "Features", 0, "a{sv}", features_getter,
> NULL);
> l_dbus_interface_property(iface, "Beacon", 0, "b", beacon_getter, NULL);
> - l_dbus_interface_property(iface, "BeaconFlags", 0, "b",
> + l_dbus_interface_property(iface, "BeaconFlags", 0, "y",
> beaconflags_getter, NULL);
> l_dbus_interface_property(iface, "IvIndex", 0, "u", ivindex_getter,
> NULL);