2020-02-07 05:10:34

by Matt Ranostay

Subject: [PATCH RESEND] obex: report notification status on incoming message

To match doc/obex.txt on incoming message notification the respective
Status field should be set.
---
obexd/client/map.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/obexd/client/map.c b/obexd/client/map.c
index 550c5afb4..23be2d6b2 100644
--- a/obexd/client/map.c
+++ b/obexd/client/map.c
@@ -1914,6 +1914,7 @@ static void map_handle_notification(struct map_event *event, void *user_data)
switch (event->type) {
case MAP_ET_NEW_MESSAGE:
map_handle_new_message(map, event);
+ map_handle_status_changed(map, event, "notification");
break;
case MAP_ET_DELIVERY_SUCCESS:
map_handle_status_changed(map, event, "delivery-success");
--
2.20.1

2020-02-11 21:42:34

by Luiz Augusto von Dentz

Subject: Re: [PATCH RESEND] obex: report notification status on incoming message

Hi Matt.

On Thu, Feb 6, 2020 at 9:12 PM Matt Ranostay <[email protected]> wrote:
>
> To match doc/obex.txt on incoming message notification the respective
> Status field should be set.
> ---
> obexd/client/map.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/obexd/client/map.c b/obexd/client/map.c
> index 550c5afb4..23be2d6b2 100644
> --- a/obexd/client/map.c
> +++ b/obexd/client/map.c
> @@ -1914,6 +1914,7 @@ static void map_handle_notification(struct map_event *event, void *user_data)
> switch (event->type) {
> case MAP_ET_NEW_MESSAGE:
> map_handle_new_message(map, event);
> + map_handle_status_changed(map, event, "notification");
> break;
> case MAP_ET_DELIVERY_SUCCESS:
> map_handle_status_changed(map, event, "delivery-success");
> --
> 2.20.1

Applied, thanks.

--
Luiz Augusto von Dentz