2020-03-10 16:33:34

by Manish Mandlik

Subject: [PATCH] Bluetooth: mgmt: add mgmt_cmd_status in add_advertising

From: Joseph Hwang <[email protected]>

From: Joseph Hwang <[email protected]>

If an error occurs during request building in add_advertising(),
remember to send MGMT_STATUS_FAILED command status back to bluetoothd.

Signed-off-by: Joseph Hwang <[email protected]>
Signed-off-by: Manish Mandlik <[email protected]>
---

net/bluetooth/mgmt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 1002c657768a0..2398f57b7dc3c 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -6747,8 +6747,11 @@ static int add_advertising(struct sock *sk, struct hci_dev *hdev,
if (!err)
err = hci_req_run(&req, add_advertising_complete);

- if (err < 0)
+ if (err < 0) {
+ err = mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING,
+ MGMT_STATUS_FAILED);
mgmt_pending_remove(cmd);
+ }

unlock:
hci_dev_unlock(hdev);
--
2.25.1.481.gfbce0eb801-goog

2020-03-11 14:36:21

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: mgmt: add mgmt_cmd_status in add_advertising

Hi Manish,

> If an error occurs during request building in add_advertising(),
> remember to send MGMT_STATUS_FAILED command status back to bluetoothd.
>
> Signed-off-by: Joseph Hwang <[email protected]>
> Signed-off-by: Manish Mandlik <[email protected]>
> ---
>
> net/bluetooth/mgmt.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel