2020-08-13 00:29:21

by Sonny Sasaka

Subject: [PATCH BlueZ] checkpatch: Ignore SPDX license tag

BlueZ does not use SPDX license tag on file headers.

---
.checkpatch.conf | 1 +
1 file changed, 1 insertion(+)

diff --git a/.checkpatch.conf b/.checkpatch.conf
index 419733832..72c3529c3 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -12,3 +12,4 @@
--ignore PREFER_PACKED
--ignore COMMIT_MESSAGE
--ignore SSCANF_TO_KSTRTO
+--ignore SPDX_LICENSE_TAG
--
2.26.2

2020-09-16 22:41:55

by Sonny Sasaka

Subject: Re: [PATCH BlueZ] checkpatch: Ignore SPDX license tag

Dear BlueZ maintainers,

I saw recent patches that BlueZ started adding SPDX license tags to
file headers. Is this where the convention is going? If so, please
ignore this patch.

On Wed, Aug 12, 2020 at 5:28 PM Sonny Sasaka <[email protected]> wrote:
>
> BlueZ does not use SPDX license tag on file headers.
>
> ---
> .checkpatch.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.checkpatch.conf b/.checkpatch.conf
> index 419733832..72c3529c3 100644
> --- a/.checkpatch.conf
> +++ b/.checkpatch.conf
> @@ -12,3 +12,4 @@
> --ignore PREFER_PACKED
> --ignore COMMIT_MESSAGE
> --ignore SSCANF_TO_KSTRTO
> +--ignore SPDX_LICENSE_TAG
> --
> 2.26.2
>

2020-09-16 23:07:02

by Luiz Augusto von Dentz

Subject: Re: [PATCH BlueZ] checkpatch: Ignore SPDX license tag

Hi Sonny,

On Wed, Sep 16, 2020 at 3:43 PM Sonny Sasaka <[email protected]> wrote:
>
> Dear BlueZ maintainers,
>
> I saw recent patches that BlueZ started adding SPDX license tags to
> file headers. Is this where the convention is going? If so, please
> ignore this patch.

Yes, it is better that way so we don't have to keep up with the
license on every file and will probably attempt do some automation to
check if SDPX Identifier is proper.

> On Wed, Aug 12, 2020 at 5:28 PM Sonny Sasaka <[email protected]> wrote:
> >
> > BlueZ does not use SPDX license tag on file headers.
> >
> > ---
> > .checkpatch.conf | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/.checkpatch.conf b/.checkpatch.conf
> > index 419733832..72c3529c3 100644
> > --- a/.checkpatch.conf
> > +++ b/.checkpatch.conf
> > @@ -12,3 +12,4 @@
> > --ignore PREFER_PACKED
> > --ignore COMMIT_MESSAGE
> > --ignore SSCANF_TO_KSTRTO
> > +--ignore SPDX_LICENSE_TAG
> > --
> > 2.26.2
> >



--
Luiz Augusto von Dentz

2020-09-16 23:24:02

by Sonny Sasaka

Subject: Re: [PATCH BlueZ] checkpatch: Ignore SPDX license tag

Hi Luiz,

Thanks for the clarification. Please do ignore this patch then.

On Wed, Sep 16, 2020 at 4:05 PM Luiz Augusto von Dentz
<[email protected]> wrote:
>
> Hi Sonny,
>
> On Wed, Sep 16, 2020 at 3:43 PM Sonny Sasaka <[email protected]> wrote:
> >
> > Dear BlueZ maintainers,
> >
> > I saw recent patches that BlueZ started adding SPDX license tags to
> > file headers. Is this where the convention is going? If so, please
> > ignore this patch.
>
> Yes, it is better that way so we don't have to keep up with the
> license on every file and will probably attempt do some automation to
> check if SDPX Identifier is proper.
>
> > On Wed, Aug 12, 2020 at 5:28 PM Sonny Sasaka <[email protected]> wrote:
> > >
> > > BlueZ does not use SPDX license tag on file headers.
> > >
> > > ---
> > > .checkpatch.conf | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/.checkpatch.conf b/.checkpatch.conf
> > > index 419733832..72c3529c3 100644
> > > --- a/.checkpatch.conf
> > > +++ b/.checkpatch.conf
> > > @@ -12,3 +12,4 @@
> > > --ignore PREFER_PACKED
> > > --ignore COMMIT_MESSAGE
> > > --ignore SSCANF_TO_KSTRTO
> > > +--ignore SPDX_LICENSE_TAG
> > > --
> > > 2.26.2
> > >
>
>
>
> --
> Luiz Augusto von Dentz